[PATCH v4 08/15] cmd: bmp: Split bmp commands and functions

[Nikhil M Jain]

Hi Simon,

On 31/03/23 01:44, Simon Glass wrote:
> Hi Nikhil,
> 
> On Thu, 30 Mar 2023 at 01:02, Nikhil M Jain <n-jain1 at ti.com> wrote:
>>
>> To enable splash screen at spl, need to compile cmd/bmp.c which also
>> includes bmp commands, since SPL can't have commands split bmp.c into
>> common/bmp.c which includes all bmp functions and cmd/bmp_cmd contains
>> bmp commands.
>>
>> Add delclaration for bmp_info in video.h.
>>
>> Signed-off-by: Nikhil M Jain <n-jain1 at ti.com>
>> ---
>> V4:
>> - No change
>>
>> V3 (patch introduced):
>> - Split bmp functions and commands
>>
>>   cmd/bmp_cmd.c         |  98 +++++++++++++++++++++++++++++++++++++++
> 
> Please can you keep this as cmd/bmp.c ?

I will keep cmd/bmp.c
> 
>>   {cmd => common}/bmp.c | 104 +-----------------------------------------
>>   include/video.h       |   7 +++
>>   3 files changed, 106 insertions(+), 103 deletions(-)
>>   create mode 100644 cmd/bmp_cmd.c
>>   rename {cmd => common}/bmp.c (62%)
>>
> 
> Otherwise looks good
> 
> [..]
> 
> Regards,
> SImon

Thanks,
Nikhil