[PATCH v2 18/30] sandbox: Disable raw Ethernet on MSYS2

Bin Meng bmeng.cn at gmail.com
Mon May 1 11:23:15 CEST 2023


Hi Simon,

On Sun, Apr 30, 2023 at 9:30 AM Simon Glass <sjg at chromium.org> wrote:
>
> This relies on Linux features so cannot be built for Windows. Drop it.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> (no changes since v1)
>
>  arch/sandbox/cpu/Makefile | 2 ++
>  drivers/net/Makefile      | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/arch/sandbox/cpu/Makefile b/arch/sandbox/cpu/Makefile
> index 7c5c52652f5c..be6b57692dd5 100644
> --- a/arch/sandbox/cpu/Makefile
> +++ b/arch/sandbox/cpu/Makefile
> @@ -9,7 +9,9 @@ obj-y   := cache.o cpu.o state.o
>  extra-y        := start.o os.o
>  extra-$(CONFIG_SANDBOX_SDL)    += sdl.o
>  obj-$(CONFIG_SPL_BUILD)        += spl.o
> +ifeq ($(MSYS_VERSION),0)
>  obj-$(CONFIG_ETH_SANDBOX_RAW)  += eth-raw-os.o
> +endif
>
>  # os.c is build in the system environment, so needs standard includes
>  # CFLAGS_REMOVE_os.o cannot be used to drop header include path
> diff --git a/drivers/net/Makefile b/drivers/net/Makefile
> index 46a40e2ed9f8..6580f8d85510 100644
> --- a/drivers/net/Makefile
> +++ b/drivers/net/Makefile
> @@ -30,8 +30,10 @@ obj-$(CONFIG_ETH_DESIGNWARE_MESON8B) += dwmac_meson8b.o
>  obj-$(CONFIG_ETH_DESIGNWARE_S700) += dwmac_s700.o
>  obj-$(CONFIG_ETH_DESIGNWARE_SOCFPGA) += dwmac_socfpga.o
>  obj-$(CONFIG_ETH_SANDBOX) += sandbox.o
> +ifeq ($(MSYS_VERSION),0)
>  obj-$(CONFIG_ETH_SANDBOX_RAW) += sandbox-raw-bus.o
>  obj-$(CONFIG_ETH_SANDBOX_RAW) += sandbox-raw.o
> +endif
>  obj-$(CONFIG_FEC_MXC) += fec_mxc.o
>  obj-$(CONFIG_FMAN_ENET) += fm/
>  obj-$(CONFIG_FMAN_ENET) += fsl_mdio.o
> --

In patch #16, you introduced CC_IS_MSYS. I think you can just make
CONFIG_ETH_SANDBNOX_RAW depend on !CC_IS_MSYS?

Regards,
Bin


More information about the U-Boot mailing list