[PATCH] env: Remove misuse of env is nowhere driver

Stefan Herbrechtsmeier stefan.herbrechtsmeier-oss at weidmueller.com
Tue May 2 12:13:49 CEST 2023


Hi Heiko,

Am 29.04.2023 um 06:30 schrieb Heiko Schocher:
> Hello Stefan,
>
> On 28.04.23 15:45, Stefan Herbrechtsmeier wrote:
>> From: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
>>
>> When using a list of writeable variables, the initial values come from
>> the built-in default environment since commit 5ab81058364b
>> ("env: Complete generic support for writable list"). Remove unnecessary
>> misuse of the env is nowhere driver as default environment.
>>
>> Signed-off-by: Stefan Herbrechtsmeier <stefan.herbrechtsmeier at weidmueller.com>
>> ---
>>
>>   board/aristainetos/aristainetos.c    | 19 -------------------
>>   configs/aristainetos2c_defconfig     |  1 -
>>   configs/aristainetos2ccslb_defconfig |  1 -
>>   env/env.c                            |  2 --
>>   4 files changed, 23 deletions(-)
> Also you mix up a change in common code and in board code.

I use one commit to avoid a breakage in between the commits but it looks 
like all affected boards use one environment source only so that a 
separation should be okay.

> And grepping in code for ENVL_NOWHERE has much more finds...

Thanks for the hint. I have recheck the code and add two additional boards.

Regards
   Stefan



More information about the U-Boot mailing list