[PATCH] arm: imx8m: remove unused and obsolete board_fix_fdt() in SOC context

sbabic at denx.de sbabic at denx.de
Tue May 2 14:46:34 CEST 2023


> From: Hugo Villeneuve <hvilleneuve at dimonoff.com>
> It doesn't seem appropriate for arch/SOC to use a board-level
> functionality (CONFIG_OF_BOARD_FIXUP), because this prevents boards
> that need to do FDT fixup from using that feature.
> Also, this code is completely dead and useless (from comments by
> Rasmus Villemoes on the mailing list):
>   - No in-tree imx8m-based board seems to set CONFIG_OF_BOARD_FIXUP
>   - The nodes which that function wants to disable don't even exist in
>     the U-Boot copy of imx8mp.dtsi.
> This code was introduced in commit 35bb60787b88. It seems to be some
> random import of code from downstream NXP U-Boot, with a commit
> message that makes no sense in upstream context.
> Signed-off-by: Hugo Villeneuve <hvilleneuve at dimonoff.com>
> Acked-by: Peng Fan <peng.fan at nxp.com>
> Reviewed-by: Fabio Estevam <festevam at denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list