[PATCH 4/4] test: bdinfo: Add test for command bdinfo

Simon Glass sjg at chromium.org
Fri May 5 02:40:35 CEST 2023


Hi Marek,

On Thu, 4 May 2023 at 10:01, Marek Vasut <marek.vasut at mailbox.org> wrote:
>
> On 5/4/23 17:51, Tom Rini wrote:
> > On Sat, Apr 22, 2023 at 03:01:34PM +0200, Marek Vasut wrote:
> >
> >> Add test for command bdinfo .
> >>
> >> Signed-off-by: Marek Vasut <marek.vasut+renesas at mailbox.org>
> >> Reviewed-by: Simon Glass <sjg at chromium.org>
> >> ---
> >> Cc: Jason Liu <jason.hui.liu at nxp.com>
> >> Cc: Michal Simek <michal.simek at amd.com>
> >> Cc: Ovidiu Panait <ovpanait at gmail.com>
> >> Cc: Simon Glass <sjg at chromium.org>
> >> ---
> >>   include/test/suites.h |   1 +
> >>   test/cmd/Makefile     |   1 +
> >>   test/cmd/bdinfo.c     | 179 ++++++++++++++++++++++++++++++++++++++++++
> >>   test/cmd_ut.c         |   6 ++
> >>   4 files changed, 187 insertions(+)
> >>   create mode 100644 test/cmd/bdinfo.c
> >
> > This breaks building on "snow" which does not set CFG_SYS_SDRAM_SIZE
> > seemingly.
>
> Isn't this macro mandatory ?
>
> Simon, can you elaborate what chromebook snow does with the DRAM there ?

It detects it at runtime, so doesn't have that symbol.

Regards,
Simon


More information about the U-Boot mailing list