[PATCH v2 15/18] spl: Commit MTRRs only in board_init_f_r()

[Simon Glass]

Hi Bin,

On Thu, 4 May 2023 at 08:22, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Tue, Apr 18, 2023 at 11:31 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > We don't need to commit the SPI-flash MTRR change immediately, since it is
> > now done in the board_init_f_r(). Also this causes chromebook_link64 to
> > hang.
>
> Could you add more details as to why this causes chromebook_link64 to hang?
>
> As I see the mtrr_commit() has been there since TPL was introduced on
> day 1, there must be some other places changes that caused the
> regression on chromebook_link64??

I went back a few years (2019.04 I think) and found that the
regression has been there quite a while. The problem was that I had a
test for link but not link64. So I think it silently broke and I
didn't notice at the time.

I'll update with a little more detail.

[..]

Regards,
Simon