[PATCH 2/3] bootstd: usb: Avoid initing USB twice

[Jonas Karlman]

On 2023-05-06 18:24, Jonas Karlman wrote:
> On 2023-05-06 18:00, Tom Rini wrote:
>> On Sat, May 06, 2023 at 03:59:57PM +0000, Jonas Karlman wrote:
>>> Hi Simon,
>>>
>>> On 2023-05-06 04:03, Simon Glass wrote:
>>>> This causes crashes on some boards, e.g. rockpro64. In any case, we
>>>> should not do it.
>>>>
>>>> Check the usb_started flag to avoid this.
>>>>
>>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>>> ---
>>>>
>>>>  drivers/usb/host/usb_bootdev.c | 3 +++
>>>>  test/boot/bootdev.c            | 5 +++++
>>>>  2 files changed, 8 insertions(+)
>>>>
>>>
>>> This fixes the crash related to usbkbd in stdin env on my rockpro64, so:
>>>
>>> Tested-by: Jonas Karlman <jonas at kwiboo.se>
>>
>> I'm also testing things out on my rockpro64 finally.  Are you able to
>> boot distributions from uSD on yours or only USB, automatically?
>>
> 
> Was able to boot Armbian after enable of script bootmeth support,
> distro/extlinux.conf bootmeth seem to work fine, just tried
> debian-11.7.0-arm64-netinst.iso and got following crash.
> 
> I have avoided efi boot thus far, not sure this was supposed to work or not.
> Was however not expecting a crash, possibly jumping to next bootflow.

With Fedora-Server-38-1.6.aarch64.raw.xz on uSD, and u-boot in eMMC,
the efi bootflow does work. Crash only happen with debian thus far.

Regards,
Jonas

> 
> ** Booting bootflow 'mmc at fe320000.bootdev.part_1' with efi
> Card did not respond to voltage select! : -110
> No EFI system partition
> No EFI system partition
> Failed to persist EFI variables
> Booting /efi\boot\bootaa64.efi
> No EFI system partition
> Failed to persist EFI variables
> "Synchronous Abort" handler, esr 0x96000010, far 0x4c
> elr: fffffffffd13f3e0 lr : fffffffffd13f41c (reloc)
> elr: 00000000f0e6a3e0 lr : 00000000f0e6a41c
> x0 : 000000000000004c x1 : 00000000f1f10060
> x2 : 0000000000000000 x3 : 0000000000000000
> x4 : 00000000000000ff x5 : 0000000000000000
> x6 : 00000000f0bec000 x7 : 0000000000000007
> x8 : 0000000000000002 x9 : fffffffffffffff0
> x10: 00000000f0f01000 x11: 00000000f0e04040
> x12: 00000000f0e6d518 x13: 00000000f3f2b000
> x14: 00000000f1f10578 x15: 00000000f0df8040
> x16: 00000000f3f8e788 x17: 000000000a68740b
> x18: 0000000000000000 x19: 00000000f1f10060
> x20: 00000000f1f10330 x21: 00000000f0e99c00
> x22: 0000000000010020 x23: 00000000f0e99caa
> x24: 00000000f1f104f0 x25: 00000000f0e84d40
> x26: 000000000000012f x27: 00000000f0e862f4
> x28: 00000000000043b0 x29: 00000000f1f0ffe0
> 
> Code: 38626800 91000442 f9000422 d65f03c0 (78627800)
> UEFI image [0x00000000f0e05000:0x00000000f0ed90a9] pc=0x653e0 '/efi\boot\bootaa64.efi'
> Resetting CPU ...
> 
> Regards,
> Jonas