U-Boot Bootmenu is broken on Nokia N900

Pali Rohár pali at kernel.org
Sun May 7 22:55:04 CEST 2023

Bootmenu on Nokia N900 is broken (on both HW and in qemu emulator).
Bootmenu just prints garbage on the screen. I run git bisect and the
result is:

72a0dd8bed010bef78028ae528763f9807758e6b is the first bad commit
commit 72a0dd8bed010bef78028ae528763f9807758e6b
Author: Simon Glass <sjg at chromium.org>
Date:   Fri Jan 6 08:52:29 2023 -0600

    video: Enable VIDEO_ANSI by default only with EFI

    This is not generally needed unless EFI_LOADER is used. Adjust the default
    setting to reduce the size of the U-Boot build.

    Signed-off-by: Simon Glass <sjg at chromium.org>

:040000 040000 7da10731b9f552cd7ff26dabe3e4787bf2b80caa 18fa5c5d7f1f14aebaa1365b8f60217bbeffabb8 M      drivers

Change was relatively simple:

diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index f539977d9b73..440b161b8423 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -112,10 +112,13 @@ config VIDEO_BPP32
 config VIDEO_ANSI
 	bool "Support ANSI escape sequences in video console"
-	default y
+	default y if EFI_LOADER
 	  Enable ANSI escape sequence decoding for a more fully functional
-	  console.
+	  console. Functionality includes changing the text colour and moving
+	  the cursor. These date from the 1970s and are still widely used today
+	  to control a text terminal. U-Boot implements these by decoding the
+	  sequences and performing the appropriate operation.
 	bool "Support MIPI DSI interface"

On master branch with CONFIG_VIDEO_ANSI=y is bootmenu rendering again.

CONFIG_VIDEO_ANSI needs to be by default enabled also when
CONFIG_CMD_BOOTMENU is enabled (not only for EFI).

Simon, would you fix it?

More information about the U-Boot mailing list