[PATCH v3 14/17] spl: Commit MTRRs only in board_init_f_r()

Bin Meng bmeng.cn at gmail.com
Mon May 8 16:53:27 CEST 2023


On Fri, May 5, 2023 at 6:51 AM Simon Glass <sjg at chromium.org> wrote:
>
> We don't need to commit the SPI-flash MTRR change immediately, since it is
> now done in the board_init_f_r(). Also this causes chromebook_link64 to
> hang, presumably since we are still running from CAR (Cache-as-RAM) in
> SPL. Coral handles this OK, perhaps since it is running from a different
> memory area, but it has no effect on Coral anyway.
>
> Drop the extra mtrr_commit() in the SPL implementation.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v3:
> - Add more detail about why it might be hanging
>
>  arch/x86/lib/spl.c | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn at gmail.com>


More information about the U-Boot mailing list