[PATCH] firmware: ti_sci: Add missing LF in error message

Andrew Davis afd at ti.com
Wed May 10 17:46:37 CEST 2023


On 5/9/23 4:38 PM, Andreas Dannenberg wrote:
> The "Message not acknowledged" error message is missing a line feed,
> leading to the console log getting garbled and joined together with
> whatever the next output is in case this error happens:
> 
> "ti_sci system-controller at 44043000: Message not acknowledgedAuthentication failed!"
> 
> Fix ths by adding the missing linefeed character.

s/ths/this

> 
> Signed-off-by: Andreas Dannenberg <dannenberg at ti.com>
> ---

Good find,

Acked-by: Andrew Davis <afd at ti.com>

>   drivers/firmware/ti_sci.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
> index bd7379ae55..72f572d824 100644
> --- a/drivers/firmware/ti_sci.c
> +++ b/drivers/firmware/ti_sci.c
> @@ -265,7 +265,7 @@ static int ti_sci_do_xfer(struct ti_sci_info *info,
>   	if (xfer->rx_len) {
>   		ret = ti_sci_get_response(info, xfer, &info->chan_rx);
>   		if (!ti_sci_is_response_ack(xfer->tx_message.buf)) {
> -			dev_err(info->dev, "Message not acknowledged");
> +			dev_err(info->dev, "Message not acknowledged\n");
>   			ret = -ENODEV;
>   		}
>   	}


More information about the U-Boot mailing list