[RFC PATCH v8 09/23] cli: Add menu for hush parser

[Heinrich Schuchardt]

On 5/12/23 22:03, Francis Laniel wrote:
> For the moment, the menu contains only entry: HUSH_OLD_PARSER which is the
> default.
> The goal is to prepare the field to add a new hush parser which guarantees
> actual behavior is still correct.
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> Signed-off-by: Francis Laniel <francis.laniel at amarulasolutions.com>
> ---
>   cmd/Kconfig     | 13 +++++++++++++
>   common/Makefile |  2 +-
>   2 files changed, 14 insertions(+), 1 deletion(-)
>
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 87291e2d84..2c50c9f7b5 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -23,6 +23,19 @@ config HUSH_PARSER
>   	  If disabled, you get the old, much simpler behaviour with a somewhat
>   	  smaller memory footprint.
>
> +menu "Hush flavor to use"
> +	depends on HUSH_PARSER
> +
> +	config HUSH_OLD_PARSER

If there will be alternative parsers in future, you should use
choice/endchoice even if there is only one option today.

Best regards

Heinrich

> +		bool "Use hush old parser"
> +		default y
> +		help
> +		  This option enables the old flavor of hush based on hush Busybox from
> +		  2005.
> +
> +		  It is actually the default U-Boot shell when decided to use hush as shell.
> +endmenu
> +
>   config CMDLINE_EDITING
>   	bool "Enable command line editing"
>   	depends on CMDLINE
> diff --git a/common/Makefile b/common/Makefile
> index c87bb2e78b..93d0a5a309 100644
> --- a/common/Makefile
> +++ b/common/Makefile
> @@ -8,7 +8,7 @@ ifndef CONFIG_SPL_BUILD
>   obj-y += init/
>   obj-y += main.o
>   obj-y += exports.o
> -obj-$(CONFIG_HUSH_PARSER) += cli_hush.o
> +obj-$(CONFIG_HUSH_OLD_PARSER) += cli_hush.o
>   obj-$(CONFIG_AUTOBOOT) += autoboot.o
>
>   # # boards