[PATCH] scripts/Makefile.dts: tweak logic for deciding which dtbs to build
Tom Rini
trini at konsulko.com
Mon May 15 23:12:45 CEST 2023
On Thu, May 04, 2023 at 01:33:08PM +0200, Rasmus Villemoes wrote:
> The idea in 3609e1dc5f4d (dts: automatically build necessary .dtb
> files) was fine, but the implementation was suboptimal due to some
> misunderstandings on my part (and possibly defects in some defconfig
> files):
>
> - Sometimes DEFAULT_DEVICE_TREE is not included in OF_LIST or
> SPL_OF_LIST
>
> - SPL_OF_LIST is not always a subset of OF_LIST
>
> - While SPL_OF_LIST governs the list of dtbs relevant to SPL (i.e.,
> may be built into an
> SPL-with-bunch-of-dtbs-to-choose-between-at-runtime), those dtbs are
> not actually _built_ during the SPL build phase, i.e. when $(SPL_)
> would expand to SPL_. fdtgrep runs on the artifacts produced during
> the ordinary U-Boot build.
>
> Tweak the logic so that we simply add the union of all dtbs mentioned
> in either DEFAULT_DEVICE_TREE, OF_LIST and SPL_OF_LIST to dtb-y. That
> should, for real, ensure that we always build all the dtbs that is
> relevant to the current board, and should in turn enable us to
> massively simplify arch/*/dts/Makefile.
>
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
> Tested-by: Tom Rini <trini at konsulko.com>
> Reviewed-by: Simon Glass <sjg at chromium.org>
Applied to u-boot/next, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230515/ae701dc5/attachment.sig>
More information about the U-Boot
mailing list