[PATCH] include: Remove unused header files

Tom Rini trini at konsulko.com
Tue May 16 17:08:12 CEST 2023


On Tue, May 16, 2023 at 04:15:18PM +0300, Eugen Hristev wrote:
> On 5/16/23 16:09, Tom Rini wrote:
> > On Tue, May 16, 2023 at 04:08:10PM +0300, Eugen Hristev wrote:
> > > On 5/15/23 21:01, Tom Rini wrote:
> > > > As part of various code clean-ups we have on occasion missed removing
> > > > unused header files.  None of these files are referenced anywhere else
> > > > at this point.
> > > > 
> > > > Signed-off-by: Tom Rini <trini at konsulko.com>
> > > > ---
> > > >    arch/arm/include/asm/arch-bcmcygnus/configs.h |   18 -
> > > >    arch/arm/include/asm/arch-bcmnsp/configs.h    |   17 -
> > > >    arch/arm/include/asm/arch-imxrt/imxrt.h       |   10 -
> > > >    arch/arm/include/asm/arch-lpc32xx/gpio_grp.h  |   39 -
> > > >    arch/arm/include/asm/arch-mx27/mxcmmc.h       |   11 -
> > > >    arch/arm/include/asm/arch-mx6/opos6ul.h       |   11 -
> > > >    arch/arm/include/asm/arch-mxs/regs-uartapp.h  |  219 ---
> > > >    arch/arm/include/asm/arch-omap3/omap3-regs.h  |   78 -
> > > >    arch/arm/include/asm/arch-omap5/mux_omap5.h   |  317 ----
> > > >    arch/arm/include/asm/iproc-common/configs.h   |   14 -
> > > >    .../include/asm/iproc-common/iproc_sdhci.h    |   12 -
> > > >    arch/arm/include/asm/kona-common/kona_sdhci.h |   11 -
> > > >    arch/arm/mach-at91/include/mach/at91_rtt.h    |   32 -
> > > >    arch/arm/mach-at91/include/mach/sama7-sfr.h   |   59 -
> > > 
> > > Hi Tom,
> > > 
> > > The sama7 SFR is to be used with patches that are pending, not yet merged.
> > > Could you please avoid removing this file ?
> > 
> > OK.  Is that the only one? For future reference, it's best to not
> > include headers / etc until they're going to be used.  Thanks.
> > 
> 
> Well, the fact is that the header file is part of the arch , thus going
> through the at91 tree, but it's referenced in some USB patches, that are
> assigned to Marek and going through the USB tree.
> Since he could not take the patches without the header, I applied it first,
> and now waiting for him to send the PR for the USB patches using it.
> You could ask why they are not in the same patch, well, Marek asked for
> separate patches for arch changes and USB changes.

Ah.  Well, while I understand why that makes sense for the Linux kernel
(there's so many subsystems and maintainers, how is one supposed to know
if something has been reviewed) I'm quite happy to see things like this
come in via one tree with the code having been acked/reviewed by the
other. Not that this is likely to be a big deal moving forward, I'm
unlikely to re-run this kind of check until after removing a number of
platforms again.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20230516/768991cd/attachment.sig>


More information about the U-Boot mailing list