[PATCH v4 1/2] ARM: dts: rk3588-rock-5b-u-boot: add bootph-all to pinctrl for sdmmc

Kever Yang kever.yang at rock-chips.com
Wed May 17 04:10:30 CEST 2023


On 2023/5/15 21:44, Eugen Hristev wrote:
> To be able to initialize the pinctrl correctly at SPL level and read
> u-boot proper from SD-Card, the pinctrl must be initialized.
>
> Signed-off-by: Eugen Hristev <eugen.hristev at collabora.com>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
> Changes in v4:
> - rebased on latest master: This is also on top of the USB 2.0 series !
> Changes in v3:
> - change to bootph-all props.
>
> Changes in v2:
> - add u-boot,dm-spl to pull up nodes, to also setup the pull control
> correctly. Also, in the loop that initializes multiple pins, only the
> first will be muxed as the loop will break when the pull up node is not
> found.
>
>   arch/arm/dts/rk3588-rock-5b-u-boot.dtsi | 26 +++++++++++++++++++++++++
>   1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> index 53d029c60e8f..e9fcb7b92eb3 100644
> --- a/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> +++ b/arch/arm/dts/rk3588-rock-5b-u-boot.dtsi
> @@ -31,6 +31,8 @@
>   };
>   
>   &pinctrl {
> +	bootph-all;
> +
>   	usb {
>   		vcc5v0_host_en: vcc5v0-host-en {
>   			rockchip,pins = <4 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
> @@ -38,11 +40,35 @@
>   	};
>   };
>   
> +&pcfg_pull_up_drv_level_2 {
> +	bootph-all;
> +};
> +
> +&pcfg_pull_up {
> +	bootph-all;
> +};
> +
>   &sdmmc {
>   	bus-width = <4>;
>   	status = "okay";
>   };
>   
> +&sdmmc_bus4 {
> +	bootph-all;
> +};
> +
> +&sdmmc_clk {
> +	bootph-all;
> +};
> +
> +&sdmmc_cmd {
> +	bootph-all;
> +};
> +
> +&sdmmc_det {
> +	bootph-all;
> +};
> +
>   &sdhci {
>   	cap-mmc-highspeed;
>   	mmc-ddr-1_8v;


More information about the U-Boot mailing list