[PATCH v2 1/9] core: read: add dev_read_addr_size_index_ptr function

Kever Yang kever.yang at rock-chips.com
Thu May 18 05:46:45 CEST 2023


On 2023/5/18 06:53, Jonas Karlman wrote:
> Add dev_read_addr_size_index_ptr function with the same functionality as
> dev_read_addr_size_index, but instead a return pointer is given.
> Use map_sysmem() function as cast for the return.
>
> Signed-off-by: Jonas Karlman <jonas at kwiboo.se>
Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
> v2:
> - New patch
>
>   drivers/core/read.c | 11 +++++++++++
>   include/dm/read.h   | 21 +++++++++++++++++++++
>   2 files changed, 32 insertions(+)
>
> diff --git a/drivers/core/read.c b/drivers/core/read.c
> index 0289a2edb6a4..d3c939530aa5 100644
> --- a/drivers/core/read.c
> +++ b/drivers/core/read.c
> @@ -150,6 +150,17 @@ fdt_addr_t dev_read_addr_size_index(const struct udevice *dev, int index,
>   		return devfdt_get_addr_size_index(dev, index, size);
>   }
>   
> +void *dev_read_addr_size_index_ptr(const struct udevice *dev, int index,
> +				   fdt_size_t *size)
> +{
> +	fdt_addr_t addr = dev_read_addr_size_index(dev, index, size);
> +
> +	if (addr == FDT_ADDR_T_NONE)
> +		return NULL;
> +
> +	return map_sysmem(addr, 0);
> +}
> +
>   void *dev_remap_addr_index(const struct udevice *dev, int index)
>   {
>   	fdt_addr_t addr = dev_read_addr_index(dev, index);
> diff --git a/include/dm/read.h b/include/dm/read.h
> index 56ac076c9f13..7dd43d61a665 100644
> --- a/include/dm/read.h
> +++ b/include/dm/read.h
> @@ -246,6 +246,20 @@ void *dev_read_addr_index_ptr(const struct udevice *dev, int index);
>   fdt_addr_t dev_read_addr_size_index(const struct udevice *dev, int index,
>   				    fdt_size_t *size);
>   
> +/**
> + * dev_read_addr_size_index_ptr() - Get the indexed reg property of a device
> + *                                  as a pointer
> + *
> + * @dev: Device to read from
> + * @index: the 'reg' property can hold a list of <addr, size> pairs
> + *	   and @index is used to select which one is required
> + * @size: place to put size value (on success)
> + *
> + * Return: pointer or NULL if not found
> + */
> +void *dev_read_addr_size_index_ptr(const struct udevice *dev, int index,
> +				   fdt_size_t *size);
> +
>   /**
>    * dev_remap_addr_index() - Get the indexed reg property of a device
>    *                               as a memory-mapped I/O pointer
> @@ -957,6 +971,13 @@ static inline fdt_addr_t dev_read_addr_size_index(const struct udevice *dev,
>   	return devfdt_get_addr_size_index(dev, index, size);
>   }
>   
> +static inline void *dev_read_addr_size_index_ptr(const struct udevice *dev,
> +						 int index,
> +						 fdt_size_t *size)
> +{
> +	return devfdt_get_addr_size_index_ptr(dev, index, size);
> +}
> +
>   static inline fdt_addr_t dev_read_addr_name(const struct udevice *dev,
>   					    const char *name)
>   {


More information about the U-Boot mailing list