[PATCH 1/1] [u-boot][master][PATCH v6] pico-imx7d: add baseboard SD card boot detect

Fabio Estevam festevam at gmail.com
Fri Nov 3 19:12:08 CET 2023


In the Subject: simply remove the [PATCH 1/1] [u-boot][master] text as
it is not useful.

On Thu, Nov 2, 2023 at 5:45 PM <egyszeregy at freemail.hu> wrote:

> -    aliases {
> -        mmc0 = &usdhc3;
> -        usb0 = &usbotg1;
> -        display0 = &lcdif;
> -    };
> +       aliases {
> +               mmc0 = &usdhc3;
> +               mmc1 = &usdhc1;
> +               usb0 = &usbotg1;
> +               display0 = &lcdif;

The indentation change should be on a separate patch.

> -       /* To enable AR8035 ouput a 125MHz clk from CLK_25M */
> +       /* To enable AR8035 output a 125MHz clk from CLK_25M */

This typo also should be part of a separate patch as well.

I applied your patch against U-Boot master and tried to build
pico-pi-imx7d_defconfig, but it failed:

/usr/bin/arm-linux-gnueabihf-ld.bfd:
board/technexion/pico-imx7d/pico-imx7d.o: in function
`mmc_get_env_dev':
/home/fabio/denx/u-boot/board/technexion/pico-imx7d/pico-imx7d.c:227:
multiple definition of `mmc_get_env_dev';
arch/arm/mach-imx/mmc_env.o:/home/fabio/denx/u-boot/arch/arm/mach-imx/mmc_env.c:21:
first defined here
  AR      spl/drivers/usb/host/built-in.o
  AR      spl/lib/built-in.o
make: *** [Makefile:1765: u-boot] Error 1
make: *** Waiting for unfinished jobs....
  AR      spl/drivers/usb/gadget/built-in.o
  AR      spl/drivers/built-in.o
  LD      spl/u-boot-spl
/usr/bin/arm-linux-gnueabihf-ld.bfd:
board/technexion/pico-imx7d/pico-imx7d.o: in function
`mmc_get_env_dev':
/home/fabio/denx/u-boot/board/technexion/pico-imx7d/pico-imx7d.c:227:
multiple definition of `mmc_get_env_dev';
arch/arm/mach-imx/mmc_env.o:/home/fabio/denx/u-boot/arch/arm/mach-imx/mmc_env.c:21:
first defined here
make[1]: *** [scripts/Makefile.spl:527: spl/u-boot-spl] Error 1
make: *** [Makefile:2054: spl/u-boot-spl] Error 2


More information about the U-Boot mailing list