[PATCH 1/1] dm: Do not enable debug messages by default

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Sat Nov 4 19:40:43 CET 2023


CONFIG_DM_WARN has a text indicating that these messages should only
provided when debugging. This implies that the setting must be default no.

We should still create debug messages.

Reported-by: Andre Przywara <andre.przywara at arm.com>
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
---
 drivers/core/Kconfig | 1 -
 include/dm/util.h    | 4 +---
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/core/Kconfig b/drivers/core/Kconfig
index fe5c41d57e..737d4590d5 100644
--- a/drivers/core/Kconfig
+++ b/drivers/core/Kconfig
@@ -48,7 +48,6 @@ config VPL_DM
 config DM_WARN
 	bool "Enable warnings in driver model"
 	depends on DM
-	default y
 	help
 	  Enable this to see warnings related to driver model.
 
diff --git a/include/dm/util.h b/include/dm/util.h
index 89206cc496..95c3527a37 100644
--- a/include/dm/util.h
+++ b/include/dm/util.h
@@ -11,9 +11,7 @@ struct dm_stats;
 #if CONFIG_IS_ENABLED(DM_WARN)
 #define dm_warn(fmt...) log(LOGC_DM, LOGL_WARNING, ##fmt)
 #else
-static inline void dm_warn(const char *fmt, ...)
-{
-}
+#define dm_warn(fmt...) log(LOGC_DM, LOGL_DEBUG, ##fmt)
 #endif
 
 struct list_head;
-- 
2.40.1



More information about the U-Boot mailing list