[PATCH v6 08/25] spl: Refactor spl_load_info->read to use units of bytes

Xavier Drudis Ferran xdrudis at tinet.cat
Mon Nov 6 13:35:16 CET 2023


Thanks for your work. I'm still reading... but...


El Sun, Nov 05, 2023 at 09:25:46PM -0500, Sean Anderson deia:
> diff --git a/include/spl.h b/include/spl.h
> index 951e136b9ea..ecfc50e0095 100644
> --- a/include/spl.h
> +++ b/include/spl.h
> @@ -297,10 +297,10 @@ struct spl_load_info {
>  	 * read() - Read from device
>  	 *
>  	 * @load: Information about the load state
> -	 * @sector: Sector number to read from (each @load->bl_len bytes)
> -	 * @count: Number of sectors to read
> +	 * @offset: Offset to read from in bytes, in multiples of @load->bl_len
> +	 * @count: Number of bytes to read, in multiples of @load->bl_len

I'm no native English speaker, but would it be easier to understand? :

+	 * @offset: Offset to read from in bytes, a multiple of @load->bl_len
+	 * @count: Number of bytes to read, a multiple of @load->bl_len





More information about the U-Boot mailing list