[PATCH v2 2/2] driver: power: regulator: add support for TPS65224 regulator

Bhargav Raviprakash bhargav.r at ltts.com
Mon Nov 6 15:07:12 CET 2023


Added support for PMIC TPS65224 regulators. Includes driver for
buck and ldo.

Signed-off-by: Bhargav Raviprakash <bhargav.r at ltts.com>
---
 drivers/power/regulator/Kconfig              |  10 +
 drivers/power/regulator/Makefile             |   1 +
 drivers/power/regulator/tps65224_regulator.c | 495 +++++++++++++++++++
 include/power/tps65224.h                     |   6 +-
 4 files changed, 510 insertions(+), 2 deletions(-)
 create mode 100644 drivers/power/regulator/tps65224_regulator.c

diff --git a/drivers/power/regulator/Kconfig b/drivers/power/regulator/Kconfig
index eb5aa38c1c..cb86025a22 100644
--- a/drivers/power/regulator/Kconfig
+++ b/drivers/power/regulator/Kconfig
@@ -408,6 +408,16 @@ config DM_REGULATOR_TPS65941
 	be configured in multi phase modes & 4 LDOs. The driver implements
 	get/set api for value and enable.
 
+config DM_REGULATOR_TPS65224
+	bool "Enable driver for TPS65224 PMIC regulators"
+        depends on PMIC_TPS65224
+	help
+	This enables implementation of driver-model regulator uclass
+	features for REGULATOR TPS65224 and the family of TPS65224 PMICs.
+	TPS65224 series of PMICs have 4 single phase BUCKs that can also
+	be configured in multi phase modes & 3 LDOs. The driver implements
+	get/set api for value and enable.
+
 config DM_REGULATOR_SCMI
 	bool "Enable driver for SCMI voltage domain regulators"
 	depends on DM_REGULATOR
diff --git a/drivers/power/regulator/Makefile b/drivers/power/regulator/Makefile
index d9e0cd5949..d4b9b7233f 100644
--- a/drivers/power/regulator/Makefile
+++ b/drivers/power/regulator/Makefile
@@ -34,6 +34,7 @@ obj-$(CONFIG_DM_REGULATOR_TPS65910) += tps65910_regulator.o
 obj-$(CONFIG_DM_REGULATOR_TPS62360) += tps62360_regulator.o
 obj-$(CONFIG_$(SPL_)DM_REGULATOR_STPMIC1) += stpmic1.o
 obj-$(CONFIG_DM_REGULATOR_TPS65941) += tps65941_regulator.o
+obj-$(CONFIG_DM_REGULATOR_TPS65224) += tps65224_regulator.o
 obj-$(CONFIG_DM_REGULATOR_SCMI) += scmi_regulator.o
 obj-$(CONFIG_$(SPL_)DM_REGULATOR_ANATOP) += anatop_regulator.o
 obj-$(CONFIG_DM_REGULATOR_TPS65219) += tps65219_regulator.o
diff --git a/drivers/power/regulator/tps65224_regulator.c b/drivers/power/regulator/tps65224_regulator.c
new file mode 100644
index 0000000000..0431556331
--- /dev/null
+++ b/drivers/power/regulator/tps65224_regulator.c
@@ -0,0 +1,495 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * (C) Copyright 2023 Texas Instruments Incorporated, <www.ti.com>
+ *
+ */
+#include <fdtdec.h>
+#include <errno.h>
+#include <dm.h>
+#include <log.h>
+#include <linux/delay.h>
+#include <power/pmic.h>
+#include <power/regulator.h>
+#include <power/tps65224.h>
+
+#define TPS65224_BUCK234_50mV_OFFSET_START_VOLT 1200000
+#define TPS65224_BUCK234_25mV_OFFSET_START_VOLT  500000
+#define TPS65224_BUCK234_50mV_OFFSET_START_VSET 0x1B
+#define TPS65224_BUCK234_25mV_OFFSET_START_VSET 0x00
+
+#define TPS65224_BUCK1_20mV_OFFSET_START_VOLT_1 1660000
+#define TPS65224_BUCK1_10mV_OFFSET_START_VOLT   1100000
+#define TPS65224_BUCK1_5mV_OFFSET_START_VOLT     600000
+#define TPS65224_BUCK1_20mV_OFFSET_START_VOLT_0  500000
+#define TPS65224_BUCK1_20mV_OFFSET_START_VSET_1 0xAB
+#define TPS65224_BUCK1_10mV_OFFSET_START_VSET   0x73
+#define TPS65224_BUCK1_5mV_OFFSET_START_VSET    0x0F
+#define TPS65224_BUCK1_20mV_OFFSET_START_VSET_0 0x0A
+
+static const char tps65224_buck_ctrl[TPS65224_BUCK_NUM] = {0x4, 0x6, 0x8, 0xA};
+static const char tps65224_buck_vout[TPS65224_BUCK_NUM] = {0xE, 0x10, 0x12, 0x14};
+static const char tps65224_ldo_ctrl[TPS65224_BUCK_NUM] = {0x1D, 0x1E, 0x1F};
+static const char tps65224_ldo_vout[TPS65224_BUCK_NUM] = {0x23, 0x24, 0x25};
+
+static int tps65224_buck_enable(struct udevice *dev, int op, bool *enable)
+{
+	int ret;
+	unsigned int adr;
+	struct dm_regulator_uclass_plat *uc_pdata;
+
+	uc_pdata = dev_get_uclass_plat(dev);
+	adr = uc_pdata->ctrl_reg;
+
+	ret = pmic_reg_read(dev->parent, adr);
+	if (ret < 0)
+		return ret;
+
+	if (op == PMIC_OP_GET) {
+		ret &= TPS65224_BUCK_MODE_MASK;
+
+		if (ret)
+			*enable = true;
+		else
+			*enable = false;
+
+		return 0;
+	} else if (op == PMIC_OP_SET) {
+		if (*enable)
+			ret |= TPS65224_BUCK_MODE_MASK;
+		else
+			ret &= ~TPS65224_BUCK_MODE_MASK;
+		ret = pmic_reg_write(dev->parent, adr, ret);
+		if (ret)
+			return ret;
+	}
+
+	return 0;
+}
+
+static int tps65224_buck_volt2val(int idx, int uV)
+{
+	if (uV > TPS65224_BUCK_VOLT_MAX)
+		return -EINVAL;
+
+	if (idx > 0) {
+		if (uV >= TPS65224_BUCK234_50mV_OFFSET_START_VOLT)
+			return (uV - TPS65224_BUCK234_50mV_OFFSET_START_VOLT) / 50000 +
+					TPS65224_BUCK234_50mV_OFFSET_START_VSET;
+		else if (uV >= TPS65224_BUCK234_25mV_OFFSET_START_VOLT)
+			return (uV - TPS65224_BUCK234_25mV_OFFSET_START_VOLT) / 25000;
+		else
+			return -EINVAL;
+	}
+
+	if (uV >= TPS65224_BUCK1_20mV_OFFSET_START_VOLT_1)
+		return (uV - TPS65224_BUCK1_20mV_OFFSET_START_VOLT_1) / 20000 +
+				TPS65224_BUCK1_20mV_OFFSET_START_VSET_1;
+	else if (uV >= TPS65224_BUCK1_10mV_OFFSET_START_VOLT)
+		return (uV - TPS65224_BUCK1_10mV_OFFSET_START_VOLT) / 10000 +
+				TPS65224_BUCK1_10mV_OFFSET_START_VSET;
+	else if (uV >= TPS65224_BUCK1_5mV_OFFSET_START_VOLT)
+		return (uV - TPS65224_BUCK1_5mV_OFFSET_START_VOLT) / 5000 +
+				TPS65224_BUCK1_5mV_OFFSET_START_VSET;
+	else if (uV >= TPS65224_BUCK1_20mV_OFFSET_START_VOLT_0)
+		return (uV - TPS65224_BUCK1_20mV_OFFSET_START_VOLT_0) / 20000 +
+				TPS65224_BUCK1_20mV_OFFSET_START_VSET_0;
+	else
+		return -EINVAL;
+}
+
+static int tps65224_buck_val2volt(int idx, int val)
+{
+	if (idx > 0) {
+		if (val > TPS65224_BUCK234_VOLT_MAX_HEX)
+			return -EINVAL;
+		else if (val >= TPS65224_BUCK234_50mV_OFFSET_START_VSET)
+			return TPS65224_BUCK234_50mV_OFFSET_START_VOLT +
+					(val - TPS65224_BUCK234_50mV_OFFSET_START_VSET) * 50000;
+		else if (val >= TPS65224_BUCK234_25mV_OFFSET_START_VSET)
+			return TPS65224_BUCK234_25mV_OFFSET_START_VOLT +
+				(val - TPS65224_BUCK234_25mV_OFFSET_START_VSET) * 25000;
+		else
+			return -EINVAL;
+	}
+
+	if (val > TPS65224_BUCK1_VOLT_MAX_HEX)
+		return -EINVAL;
+	else if (val >= TPS65224_BUCK1_20mV_OFFSET_START_VSET_1)
+		return TPS65224_BUCK1_20mV_OFFSET_START_VOLT_1 +
+				(val - TPS65224_BUCK1_20mV_OFFSET_START_VSET_1) * 20000;
+	else if (val >= TPS65224_BUCK1_10mV_OFFSET_START_VSET)
+		return TPS65224_BUCK1_10mV_OFFSET_START_VOLT +
+				(val - TPS65224_BUCK1_10mV_OFFSET_START_VSET) * 10000;
+	else if (val >= TPS65224_BUCK1_5mV_OFFSET_START_VSET)
+		return TPS65224_BUCK1_5mV_OFFSET_START_VOLT +
+				(val - TPS65224_BUCK1_5mV_OFFSET_START_VSET) * 5000;
+	else if (val >= TPS65224_BUCK1_20mV_OFFSET_START_VSET_0)
+		return TPS65224_BUCK1_20mV_OFFSET_START_VOLT_0 +
+				(val - TPS65224_BUCK1_20mV_OFFSET_START_VSET_0) * 20000;
+	else
+		return -EINVAL;
+}
+
+int tps65224_lookup_slew(int id)
+{
+	switch (id) {
+	case 0:
+		return 10000;
+	case 1:
+		return 5000;
+	case 2:
+		return 2500;
+	case 3:
+		return 1250;
+	default:
+		return -1;
+	}
+}
+
+static int tps65224_buck_val(struct udevice *dev, int op, int *uV)
+{
+	unsigned int hex, adr;
+	int ret, idx, delta, uwait, slew;
+	struct dm_regulator_uclass_plat *uc_pdata;
+
+	idx = dev->driver_data;
+	idx = (idx == 12) ? 0 : (idx - 1);
+
+	uc_pdata = dev_get_uclass_plat(dev);
+
+	if (op == PMIC_OP_GET)
+		*uV = 0;
+
+	adr = uc_pdata->volt_reg;
+
+	ret = pmic_reg_read(dev->parent, adr);
+	if (ret < 0)
+		return ret;
+
+	ret &= TPS65224_BUCK_VOLT_MASK;
+	ret = tps65224_buck_val2volt(idx, ret);
+	if (ret < 0)
+		return ret;
+
+	if (op == PMIC_OP_GET) {
+		*uV = ret;
+		return 0;
+	}
+
+	/*
+	 * Compute the delta voltage, find the slew rate and wait
+	 * for the appropriate amount of time after voltage switch
+	 */
+	if (*uV > ret)
+		delta = *uV - ret;
+	else
+		delta = ret - *uV;
+
+	slew = pmic_reg_read(dev->parent, uc_pdata->ctrl_reg + 1);
+	if (slew < 0)
+		return ret;
+
+	slew &= TP65224_BUCK_CONF_SLEW_MASK;
+	slew = tps65224_lookup_slew(slew);
+	if (slew <= 0)
+		return ret;
+
+	uwait = delta / slew;
+
+	hex = tps65224_buck_volt2val(idx, *uV);
+	if (hex < 0)
+		return hex;
+
+	ret &= 0x0;
+	ret = hex;
+
+	ret = pmic_reg_write(dev->parent, adr, ret);
+
+	udelay(uwait);
+
+	return ret;
+}
+
+static int tps65224_ldo_enable(struct udevice *dev, int op, bool *enable)
+{
+	int ret;
+	unsigned int adr;
+	struct dm_regulator_uclass_plat *uc_pdata;
+
+	uc_pdata = dev_get_uclass_plat(dev);
+	adr = uc_pdata->ctrl_reg;
+
+	ret = pmic_reg_read(dev->parent, adr);
+	if (ret < 0)
+		return ret;
+
+	if (op == PMIC_OP_GET) {
+		ret &= TPS65224_LDO_MODE_MASK;
+
+		if (ret)
+			*enable = true;
+		else
+			*enable = false;
+
+		return 0;
+	} else if (op == PMIC_OP_SET) {
+		if (*enable)
+			ret |= TPS65224_LDO_MODE_MASK;
+		else
+			ret &= ~TPS65224_LDO_MODE_MASK;
+		ret = pmic_reg_write(dev->parent, adr, ret);
+		if (ret)
+			return ret;
+	}
+
+	return 0;
+}
+
+static int tps65224_ldo_volt2val(int idx, int uV)
+{
+	int base = TPS65224_LDO1_VOLT_MIN;
+	int max = TPS65224_LDO1_VOLT_MAX;
+	int offset = TPS65224_LDO1_VSET_MIN;
+	int step = TPS65224_LDO123_STEP;
+
+	if (idx > 0) {
+		base = TPS65224_LDO23_VOLT_MIN;
+		max = TPS65224_LDO23_VOLT_MAX;
+		offset = TPS65224_LDO23_VSET_MIN;
+		step = TPS65224_LDO123_STEP;
+	}
+
+	if (uV > max)
+		return -EINVAL;
+	else if (uV >= base)
+		return (uV - base) / step + offset;
+	else
+		return -EINVAL;
+}
+
+static int tps65224_ldo_val2volt(int idx, int val)
+{
+	int reg_base = TPS65224_LDO1_VSET_MIN;
+	int reg_max = TPS65224_LDO1_VSET_MAX;
+	int base = TPS65224_LDO1_VOLT_MIN;
+	int max = TPS65224_LDO1_VOLT_MAX;
+	int step = TPS65224_LDO123_STEP;
+	int mask = TPS65224_LDO_VOLT_MASK >> 1;
+
+	if (idx > 0) {
+		base = TPS65224_LDO23_VOLT_MIN;
+		max = TPS65224_LDO23_VOLT_MAX;
+		reg_base = TPS65224_LDO123_VSET_MIN;
+		reg_max = TPS65224_LDO23_VSET_MAX;
+		step = TPS65224_LDO123_STEP;
+	}
+
+	val = val >> 1;
+	if (val > mask || val < 0)
+		return -EINVAL;
+	else if (val >= reg_max)
+		return max;
+	else if (val <= reg_base)
+		return base;
+	else if (val >= 0)
+		return base + (step * (val - reg_base));
+	else
+		return -EINVAL;
+}
+
+static int tps65224_ldo_val(struct udevice *dev, int op, int *uV)
+{
+	unsigned int hex, adr;
+	int ret, ret_volt;
+	struct dm_regulator_uclass_plat *uc_pdata;
+	int idx;
+
+	idx = dev->driver_data - 1;
+	uc_pdata = dev_get_uclass_plat(dev);
+
+	if (op == PMIC_OP_GET)
+		*uV = 0;
+
+	adr = uc_pdata->volt_reg;
+
+	ret = pmic_reg_read(dev->parent, adr);
+	if (ret < 0)
+		return ret;
+
+	ret &= TPS65224_LDO_VOLT_MASK;
+
+	ret_volt = tps65224_ldo_val2volt(idx, ret);
+
+	if (ret_volt < 0)
+		return ret_volt;
+
+	if (op == PMIC_OP_GET) {
+		*uV = ret_volt;
+		return 0;
+	}
+
+	/* LDO1 in BYPASS mode only supports 2.2V min to 3.6V max */
+	if (idx == 0 && (ret & BIT(TPS65224_LDO123_BYP_CONFIG)) &&
+	    *uV < TPS65224_LDO1_VOLT_BYP_MIN)
+		return -EINVAL;
+
+	/* LDO2 & LDO3 in BYPASS mode supports 1.5V min to 5.5V max */
+	if (idx > 0 && (ret & BIT(TPS65224_LDO123_BYP_CONFIG)) &&
+	    *uV < TPS65224_LDO23_VOLT_BYP_MIN)
+		return -EINVAL;
+
+	hex = tps65224_ldo_volt2val(idx, *uV);
+	if (hex < 0)
+		return hex;
+
+	hex = hex << TPS65224_LDO_MODE_MASK;
+
+	ret &= ~TPS65224_LDO_VOLT_MASK;
+	ret |= hex;
+
+	ret = pmic_reg_write(dev->parent, adr, ret);
+
+	return ret;
+}
+
+static int tps65224_ldo_probe(struct udevice *dev)
+{
+	struct dm_regulator_uclass_plat *uc_pdata;
+	int idx;
+
+	uc_pdata = dev_get_uclass_plat(dev);
+	uc_pdata->type = REGULATOR_TYPE_LDO;
+
+	idx = dev->driver_data;
+	if (idx == 1 || idx == 2 || idx == 3) {
+		debug("Single phase regulator\n");
+	} else {
+		printf("Wrong ID for regulator\n");
+		return -EINVAL;
+	}
+
+	uc_pdata->ctrl_reg = tps65224_ldo_ctrl[idx - 1];
+	uc_pdata->volt_reg = tps65224_ldo_vout[idx - 1];
+
+	return 0;
+}
+
+static int tps65224_buck_probe(struct udevice *dev)
+{
+	struct dm_regulator_uclass_plat *uc_pdata;
+	int idx;
+
+	uc_pdata = dev_get_uclass_plat(dev);
+	uc_pdata->type = REGULATOR_TYPE_BUCK;
+
+	idx = dev->driver_data;
+	if (idx == 1 || idx == 2 || idx == 3 || idx == 4) {
+		debug("Single phase regulator\n");
+	} else if (idx == 12) {
+		idx = 1;
+	} else {
+		printf("Wrong ID for regulator\n");
+		return -EINVAL;
+	}
+
+	uc_pdata->ctrl_reg = tps65224_buck_ctrl[idx - 1];
+	uc_pdata->volt_reg = tps65224_buck_vout[idx - 1];
+
+	return 0;
+}
+
+static int ldo_get_value(struct udevice *dev)
+{
+	int uV;
+	int ret;
+
+	ret = tps65224_ldo_val(dev, PMIC_OP_GET, &uV);
+	if (ret)
+		return ret;
+
+	return uV;
+}
+
+static int ldo_set_value(struct udevice *dev, int uV)
+{
+	return tps65224_ldo_val(dev, PMIC_OP_SET, &uV);
+}
+
+static int ldo_get_enable(struct udevice *dev)
+{
+	bool enable = false;
+	int ret;
+
+	ret = tps65224_ldo_enable(dev, PMIC_OP_GET, &enable);
+	if (ret)
+		return ret;
+
+	return enable;
+}
+
+static int ldo_set_enable(struct udevice *dev, bool enable)
+{
+	return tps65224_ldo_enable(dev, PMIC_OP_SET, &enable);
+}
+
+static int buck_get_value(struct udevice *dev)
+{
+	int uV;
+	int ret;
+
+	ret = tps65224_buck_val(dev, PMIC_OP_GET, &uV);
+	if (ret)
+		return ret;
+
+	return uV;
+}
+
+static int buck_set_value(struct udevice *dev, int uV)
+{
+	return tps65224_buck_val(dev, PMIC_OP_SET, &uV);
+}
+
+static int buck_get_enable(struct udevice *dev)
+{
+	bool enable = false;
+	int ret;
+
+	ret = tps65224_buck_enable(dev, PMIC_OP_GET, &enable);
+	if (ret)
+		return ret;
+
+	return enable;
+}
+
+static int buck_set_enable(struct udevice *dev, bool enable)
+{
+	return tps65224_buck_enable(dev, PMIC_OP_SET, &enable);
+}
+
+static const struct dm_regulator_ops tps65224_ldo_ops = {
+	.get_value  = ldo_get_value,
+	.set_value  = ldo_set_value,
+	.get_enable = ldo_get_enable,
+	.set_enable = ldo_set_enable,
+};
+
+U_BOOT_DRIVER(tps65224_ldo) = {
+	.name = TPS65224_LDO_DRIVER,
+	.id = UCLASS_REGULATOR,
+	.ops = &tps65224_ldo_ops,
+	.probe = tps65224_ldo_probe,
+};
+
+static const struct dm_regulator_ops tps65224_buck_ops = {
+	.get_value  = buck_get_value,
+	.set_value  = buck_set_value,
+	.get_enable = buck_get_enable,
+	.set_enable = buck_set_enable,
+};
+
+U_BOOT_DRIVER(tps65224_buck) = {
+	.name = TPS65224_BUCK_DRIVER,
+	.id = UCLASS_REGULATOR,
+	.ops = &tps65224_buck_ops,
+	.probe = tps65224_buck_probe,
+};
diff --git a/include/power/tps65224.h b/include/power/tps65224.h
index 24e91b6a67..c89317f03a 100644
--- a/include/power/tps65224.h
+++ b/include/power/tps65224.h
@@ -36,8 +36,10 @@
 /* BYPASS is bit7 of VOUT TPS65224_LDO_BYP_MASK */
 #define TPS65224_LDO123_BYP_CONFIG        7
 
-#define TPS65224_LDO123_VOLT_BYP_MIN      2200000
-#define TPS65224_LDO123_VOLT_BYP_MAX      3600000
+#define TPS65224_LDO1_VOLT_BYP_MIN        2200000
+#define TPS65224_LDO1_VOLT_BYP_MAX        3600000
+#define TPS65224_LDO23_VOLT_BYP_MIN       1500000
+#define TPS65224_LDO23_VOLT_BYP_MAX       5500000
 #define TPS65224_LDO1_VOLT_MIN            1200000
 #define TPS65224_LDO23_VOLT_MIN           600000
 #define TPS65224_LDO4_VOLT_MIN            1200000
-- 
2.25.1



More information about the U-Boot mailing list