[PATCH 2/4] serial: s5p: Use livetree API to get "id" property

[Simon Glass]

Hi Sam,

On Tue, 7 Nov 2023 at 12:06, Sam Protsenko <semen.protsenko at linaro.org> wrote:
>
> Use dev_read_u8_default() instead of fdtdec_get_int() to read the "id"
> property from device tree, as suggested in [1]. dev_* API is already
> used in this driver, so there is no reason to stick to fdtdec_* API.
> This also fixes checkpatch warning:
>
>     WARNING: Use the livetree API (dev_read_...)
>
> [1] doc/develop/driver-model/livetree.rst
>
> Signed-off-by: Sam Protsenko <semen.protsenko at linaro.org>
> ---
>  drivers/serial/serial_s5p.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c
> index 177215535676..c57bdd059ea6 100644
> --- a/drivers/serial/serial_s5p.c
> +++ b/drivers/serial/serial_s5p.c
> @@ -20,8 +20,6 @@
>  #include <serial.h>
>  #include <clk.h>
>
> -DECLARE_GLOBAL_DATA_PTR;
> -
>  enum {
>         PORT_S5P = 0,
>         PORT_S5L
> @@ -220,8 +218,7 @@ static int s5p_serial_of_to_plat(struct udevice *dev)
>
>         plat->reg = (struct s5p_uart *)addr;
>         plat->reg_width = dev_read_u32_default(dev, "reg-io-width", 1);
> -       plat->port_id = fdtdec_get_int(gd->fdt_blob, dev_of_offset(dev),
> -                                       "id", dev_seq(dev));
> +       plat->port_id = dev_read_u8_default(dev, "id", dev_seq(dev));
>
>         if (port_type == PORT_S5L) {
>                 plat->rx_fifo_count_shift = S5L_RX_FIFO_COUNT_SHIFT;
> --
> 2.39.2
>

Really this property should not be needed anymore. Can you figure out
how to drop it?

Regards,
Simon