[PATCH] net: Make NET imply NETDEVICES

Simon Glass sjg at chromium.org
Thu Nov 9 02:15:11 CET 2023


On Wed, 8 Nov 2023 at 17:12, Tom Rini <trini at konsulko.com> wrote:
>
> Normally, when NET is enabled, CMD_NET will then be enabled and in turn
> NETDEVICES will (likely) be enabled via imply. However, if we disable
> CMDLINE in a defconfig we now no longer get CMD_NET enabling NETDEVICES
> for us. This suggestion (as an imply is) really isn't about the network
> commands but network itself and is a legacy of how intertwined
> NET/CMD_NET were historically. Move this over to the NET entry instead
> where it is a more logical fit.
>
> Reported-by: Simon Glass <sjg at chromium.org>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> This could also be dropping the imply from cmd/Kconfig and instead
> making drivers/net/Kconfig::NETDEVICES be default y, which is what it
> practically is today. This would require a more lengthy check however to
> be sure there's no functional change and I'm not sure it's any better or
> worse than this approach.
> ---
>  cmd/Kconfig | 1 -
>  net/Kconfig | 1 +
>  2 files changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg at chromium.org>
Tested-by: Simon Glass <sjg at chromium.org>

Thanks!


More information about the U-Boot mailing list