[PATCH] scsi: Have scsi_init_dev_desc_priv() use memset

Simon Glass sjg at chromium.org
Thu Nov 9 02:15:33 CET 2023


On Wed, 8 Nov 2023 at 12:28, Tom Rini <trini at konsulko.com> wrote:
>
> When we do not have CONFIG_BOUNCE_BUFFER enabled, inside of
> scsi_init_dev_desc_priv we never set the 'bb' field to false, we only
> initialize it to true when CONFIG_BOUNCE_BUFFER is set. Given that we
> have a number of other fields here we had been explicitly setting to
> zero, change to first calling memset to clear the struct and then
> initialize only the fields that need non-zero default values.
>
> Addresses-Coverity-ID: 467407 ("Uninitialized variables (UNINIT)")
> Fixes: 81bd22e935dc ("rockchip: block: blk-uclass: add bounce buffer flag to blk_desc")
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> Cc: Johan Jonker <jbx6244 at gmail.com>
> ---
>  drivers/scsi/scsi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list