[PATCH 1/2] configs: rockchip: Use dwc3-generic driver on RK3328 and RK3399

[Kever Yang]

Hi Jonas, Marek,

On 2023/10/20 12:23, Marek Vasut wrote:
> On 10/19/23 22:39, Jonas Karlman wrote:
>> On 2023-10-19 01:44, Marek Vasut wrote:
>>> On 10/19/23 00:30, Jonas Karlman wrote:
>>>
>>> [..]
>>>
>>>> +++ b/configs/rock960-rk3399_defconfig
>>>> @@ -50,6 +50,7 @@ CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>>>>    CONFIG_SYS_MMC_ENV_DEV=1
>>>>    CONFIG_ROCKCHIP_GPIO=y
>>>>    CONFIG_SYS_I2C_ROCKCHIP=y
>>>> +CONFIG_MISC=y
>>>>    CONFIG_MMC_DW=y
>>>>    CONFIG_MMC_DW_ROCKCHIP=y
>>>>    CONFIG_MMC_SDHCI=y
>>>> @@ -70,12 +71,12 @@ CONFIG_SYS_NS16550_MEM32=y
>>>>    CONFIG_SYSRESET=y
>>>>    CONFIG_USB=y
>>>>    CONFIG_USB_XHCI_HCD=y
>>>> -CONFIG_USB_XHCI_DWC3=y
>>>>    CONFIG_USB_EHCI_HCD=y
>>>>    CONFIG_USB_EHCI_GENERIC=y
>>>>    CONFIG_USB_OHCI_HCD=y
>>>>    CONFIG_USB_OHCI_GENERIC=y
>>>>    CONFIG_USB_DWC3=y
>>>> +CONFIG_USB_DWC3_GENERIC=y
>>>
>>> Why not add 'default y if ROCKCHIP' into the Kconfig instead ? This 
>>> will
>>> have the same effect, without requiring such massive modification of
>>> config files.
>>
>> Not fully sure what you mean by this and how that would reduce number of
>> affected defconfig-files. The USB_XHCI_DWC3 should still be removed from
>> these defconfig-files or wrong driver could be used by these boards.
>>
>> Touching the defconfig-files help notify board maintainers that changes
>> are happening to their boards.

This patch including remove old Kconfig option and add new option, just 
move to

enable generic driver option in Kconfig file instead of defconfig file.

>>
>> There will also be a separate patch that remove the rockchip,rk3399-dwc3
>> compatible from the dwc3-of-simple driver to finalize this transition to
>> use dwc3-generic driver for affected rockchip boards.
>
> It wasn't clear to me you're switching one driver to another, thanks 
> for clarification.
>
> "
> Also enable DM_USB_GADGET for any board that enable
> USB_DWC3_GADGET.
> "
>
> This you can do in Kconfig file, something like:
> select DM_USB_GADGET if USB_DWC3_GADGET && <rockchip>

Not all the rockchip socs have usb dwc3 controller, so make this change 
in SoC level will be better.


Thanks,

- Kever