[PATCH v11 08/24] cli: Port Busybox 2021 hush to U-Boot

Tom Rini trini at konsulko.com
Thu Nov 9 14:37:31 CET 2023


On Tue, Nov 07, 2023 at 11:41:05PM +0200, Francis Laniel wrote:

> Adds new file cli_hush_2021.c, it is a copy of Busybox hush file as it was of
> time to commit 37460f5da.

I'm not sure where best to say this in the series so I'll try here. I
think we should name the hush.c file being imported from busybox as
"cli_hush_upstream.c" and the u-boot glue file around it as
"cli_hush_modern.c". Then instead of "CLI_HUSH_2021" etc,
"CLI_HUSH_MODERN" and then in due time, we drop CLI_HUSH_OLD and rename
CLI_HUSH_MODERN to CLI_HUSH.

> This commit modifies Busybox hush to not compile some part specific to Busybox
> and adds some code needed by U-Boot.
> The modifications consists mainly on adding code #if(n)def guards.

This patch is also where we should make the one line removal of
"# undef CONFIG_FEATURE_SH_STANDALONE" from the upstream file, for CI.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231109/12cf9dcf/attachment.sig>


More information about the U-Boot mailing list