[PATCH 3/7] fdt: Improve the comment for fdt_shrink_to_minimum()

Simon Glass sjg at chromium.org
Sun Nov 12 16:27:46 CET 2023


Add a bit more detail about what this function does.

Signed-off-by: Simon Glass <sjg at chromium.org>
---

 boot/fdt_support.c    |  1 -
 include/fdt_support.h | 12 +++++++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/boot/fdt_support.c b/boot/fdt_support.c
index 09ce5828659e..510ad24a999d 100644
--- a/boot/fdt_support.c
+++ b/boot/fdt_support.c
@@ -722,7 +722,6 @@ int fdt_record_loadable(void *blob, u32 index, const char *name,
 	return node;
 }
 
-/* Resize the fdt to its actual size + a bit of padding */
 int fdt_shrink_to_minimum(void *blob, uint extrasize)
 {
 	int i;
diff --git a/include/fdt_support.h b/include/fdt_support.h
index d967118bedf0..791258ec7eff 100644
--- a/include/fdt_support.h
+++ b/include/fdt_support.h
@@ -242,13 +242,23 @@ int ft_system_setup(void *blob, struct bd_info *bd);
 void set_working_fdt_addr(ulong addr);
 
 /**
- * shrink down the given blob to minimum size + some extrasize if required
+ * fdt_shrink_to_minimum() - shrink FDT while allowing for some margin
+ *
+ * Shrink down the given blob to 'minimum' size + some extrasize.
+ *
+ * The new size is enough to hold the existing contents plus @extrasize bytes,
+ * plus 5 memory reservations. Also, the end of the FDT is aligned to a 4KB
+ * boundary, so it might end up up to 4KB larger than needed.
+ *
+ * If there is an existing memory reservation for @blob in the FDT, it is
+ * updated for the new size.
  *
  * @param blob		FDT blob to update
  * @param extrasize	additional bytes needed
  * Return: 0 if ok, or -FDT_ERR_... on error
  */
 int fdt_shrink_to_minimum(void *blob, uint extrasize);
+
 int fdt_increase_size(void *fdt, int add_len);
 
 int fdt_delete_disabled_nodes(void *blob);
-- 
2.42.0.869.gea05f2083d-goog



More information about the U-Boot mailing list