Bug in distro_efi_boot()

Heinrich Schuchardt xypron.glpk at gmx.de
Thu Nov 16 01:54:26 CET 2023


Hello Simon,

In function distro_efi_boot() the bootefi command is called. The second
argument should only be passed if a device-tree has actually been
loaded. But this is not what the code does:

For network boot methods the value of $fdt_addr_r is passed as second
parameter though possibly no file has been loaded there. We should not
pass a second parameter to bootefi in this case if no device-tree was
loaded. The bootefi command will fall back to the U-Boot device-tree in
this case.

For other boot methods gd->fdt_blob is passed as second parameter. We
should not pass a second parameter in this case either.

Best regards

Heinrich


More information about the U-Boot mailing list