[PATCH] bootstd: Avoid freeing a non-allocated buffer

[Simon Glass]

Hi Shantur,

On Thu, 16 Nov 2023 at 09:45, Shantur Rathore <i at shantur.com> wrote:
>
> Hi Simon,
>
>
> > [please can you avoid top-posting as it makes it had for people to read later]
> >
>
> Sure thing.

Thanks!

>
> > There is a pending series there which I haven't got to yet.
> >
> I can add that change to my bootmeth_efi dhcp fixes patch series if you want.

Yes please

>
> > BTW, for this patch we need a test which covers EFI on sandbox,
> > perhaps running the helloworld program. The current bootstd testing
> > does not extend into the efi_loader code, so there is really no
> > coverage of the code in efi_exit_boot_services() from bootstd.
>
> I am not sure how sandbox works.
> I was able to test my setup which was crashing and was fixed after
> these changes.

OK, good. In that case we normally send 'Tested-by: My Name
<my at email.com." response to the email. That is then picked up in
patchwork [1].

For sandbox see [1]. For testing see [2] [3]

Basically sandbox is U-Boot running on Linux as a normal app. Most
feature development and testing happens there. It uses primitive
emulators for devices so that things like the display, i2c and SPI
work. That allows us to write very simple and fast tests.

The standard boot tests are all prefixed with 'bootstd' so can be run
by themselves using that name.

[..]

Regards,
Simon

[1] https://docs.u-boot.org/en/latest/arch/sandbox/sandbox.html
[2] https://docs.u-boot.org/en/latest/develop/testing.html
[3] https://docs.u-boot.org/en/latest/develop/tests_sandbox.html