[PATCH] arm: Enable SYS_THUMB_BUILD on AT91

Eugen Hristev eugen.hristev at collabora.com
Fri Nov 17 12:58:35 CET 2023


On 11/17/23 11:15, Mihai.Sain at microchip.com wrote:
> Hi Eugen,
> 
> I built new binaries with CONFIG_SYS_THUMB_BUILD=y for sam9x60_curiosity, sama5d29_curiosity, sama7g5ek and new sam9x75_curiosity board.
> I used the latest u-boot/master branch for this test.
> I noticed that the file size of the binaries have beed reduced with aprox 150KiB due to CONFIG_SYS_THUMB_BUILD=y.
> After flashing the new binaries on these boards I can confirm that on all boards the linux kernel was booted properly from mmc, qspi-flash, nand-flash and usb.
> I tested using bootm and bootz commands.

Thank you Mihai,

Tom, Sean, are you okay with this going in the next merge window ?
It is definitely not a fix, so that would be the best.

Eugen

> 
> Best regards,
> Mihai Sain
> 
> --------------------------------------------------------------------
> 
> On 11/16/23 20:47, Tom Rini wrote:
>> On Sat, Nov 04, 2023 at 10:27:42PM -0400, Sean Anderson wrote:
>>
>>> Several AT91 boards are quite close to their SPL size limit. For
>>> example, sama5d27_wlsom1_ek_mmc is just 173 bytes short of its limit
>>> and doesn't even fit with older GCCs.
>>>
>>> All AT91 processors should have thumb support. Enable
>>> SYS_THUMB_BUILD. This shrinks SPL by around 30%.
>>>
>>> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
>>> ---
>>> This has been BUILD TESTED ONLY!
>>
>> We in turn need this for Sean's other cleanup series to go in. Is this
>> OK? Would it be safer if it was only for CPU_V7A ? I do have
>> recollections of thumb being sometimes buggy prior to v7a cores. Thanks!
>>
> 
> Hi Tom,
> 
> I would like this to be tested on a few boards at least. There are boards with Cortex A5, A7 and ARM926 which are important, one of each of them and booting Linux should be enough I think.
> Nicolas, Aubin ? I remember you guys have also a CI tool that is fairly easy to use if you just push a branch/commit.
> 
> + Mihai as well.
> 
> Eugen



More information about the U-Boot mailing list