[PATCH 1/1] cmd: eficonfig: create shortened boot options

[Ilias Apalodimas]

Hi Heinrich

On Fri, 17 Nov 2023 at 01:08, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> The boot options created by eficonfig should use shortened device-paths to
> avoid problems if drives are enumerated in a different sequence.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  cmd/eficonfig.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/cmd/eficonfig.c b/cmd/eficonfig.c
> index e6e8a0a488..3d95092109 100644
> --- a/cmd/eficonfig.c
> +++ b/cmd/eficonfig.c
> @@ -528,6 +528,7 @@ struct efi_device_path *eficonfig_create_device_path(struct efi_device_path *dp_
>         p += fp_size;
>         *((struct efi_device_path *)p) = END;
>
> +       dp_volume = efi_dp_shorten(dp_volume);

efi_dp_shorten can return null.  Dont we need to check that here?

Thanks
/Ilias
>         dp = efi_dp_append(dp_volume, (struct efi_device_path *)buf);
>         free(buf);
>
> --
> 2.40.1
>