[PATCH v2 07/32] bootm: Drop arguments from bootm_start()

Ilias Apalodimas ilias.apalodimas at linaro.org
Sat Nov 18 08:51:39 CET 2023


On Thu, 16 Nov 2023 at 06:11, Simon Glass <sjg at chromium.org> wrote:
>
> This function does not use its arguments. Drop them.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Tom Rini <trini at konsulko.com>
> ---

Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>

>
> (no changes since v1)
>
>  boot/bootm.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/boot/bootm.c b/boot/bootm.c
> index cb61485c226c..fda97706fc26 100644
> --- a/boot/bootm.c
> +++ b/boot/bootm.c
> @@ -69,8 +69,7 @@ static void boot_start_lmb(struct bootm_headers *images)
>  static inline void boot_start_lmb(struct bootm_headers *images) { }
>  #endif
>
> -static int bootm_start(struct cmd_tbl *cmdtp, int flag, int argc,
> -                      char *const argv[])
> +static int bootm_start(void)
>  {
>         memset((void *)&images, 0, sizeof(images));
>         images.verify = env_get_yesno("verify");
> @@ -783,7 +782,7 @@ int do_bootm_states(struct cmd_tbl *cmdtp, int flag, int argc,
>          * any error.
>          */
>         if (states & BOOTM_STATE_START)
> -               ret = bootm_start(cmdtp, flag, argc, argv);
> +               ret = bootm_start();
>
>         if (!ret && (states & BOOTM_STATE_PRE_LOAD))
>                 ret = bootm_pre_load(cmdtp, flag, argc, argv);
> --
> 2.43.0.rc0.421.g78406f8d94-goog
>


More information about the U-Boot mailing list