[PATCH 4/5] sandbox: Audit config.h and common.h usage

[Tom Rini]

On Sat, Nov 18, 2023 at 10:09:55AM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Fri, 17 Nov 2023 at 15:54, Tom Rini <trini at konsulko.com> wrote:
> >
> > Remove and replace common.h and config.h in sandbox when it's not needed
> > and add some explicit includes where needed.
> >
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > ---
> >  arch/sandbox/cpu/cache.c         | 1 -
> >  arch/sandbox/cpu/cpu.c           | 1 -
> >  arch/sandbox/cpu/sdl.c           | 2 +-
> >  arch/sandbox/cpu/spl.c           | 1 -
> >  arch/sandbox/cpu/start.c         | 2 +-
> >  arch/sandbox/cpu/state.c         | 2 +-
> >  arch/sandbox/include/asm/io.h    | 2 ++
> >  arch/sandbox/include/asm/state.h | 1 -
> >  arch/sandbox/lib/bootm.c         | 1 -
> >  arch/sandbox/lib/fdt_fixup.c     | 1 -
> >  arch/sandbox/lib/interrupts.c    | 1 -
> >  arch/sandbox/lib/pci_io.c        | 1 -
> >  board/sandbox/sandbox.c          | 2 +-
> >  13 files changed, 6 insertions(+), 12 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Is it possible to move CFG_SYS_SDRAM_BASE/SIZE to Kconfig?

Possible? Sure. But I think it would end up being fairly horrible. What
would be nice I think is some Zephyr-style "convert
CONFIG_DEFAULT_DEVICE_TREE to some defines" because we could parse out
/memory to CFG_SYS_SDRAM_BASE/SIZE and that's something we _need_ at
build time.

> For CFG_SYS_BAUDRATE_TABLE perhaps we could have a standard set that
> most boards use, or turn it into a set of word flags with a bit for
> each rate?

We do, largely, use a default table. I forget which further rework I
posted as an RFC a few years ago, but I believe it was largely seen as
being uglier than what we have today.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231118/8954c06c/attachment.sig>