[PATCH v2 1/5] cyclic: Add a symbol for SPL

[Simon Glass]

Hi Tom,

On Tue, 21 Nov 2023 at 06:06, Tom Rini <trini at konsulko.com> wrote:
>
> On Mon, Nov 20, 2023 at 07:09:25PM -0700, Simon Glass wrote:
>
> > The cyclic subsystem is currently enabled either in all build phases
> > or none. For tools this should not be enabled, but since lib/shc256.c
> > and other files include watchdog.h in the host build, we must make
> > sure that it is not enabled there.
> >
> > Add an SPL symbol so that there is more control of this.
> >
> > Add an include into cyclic.h so that tools can include this file.
> >
> > Also add the kconfig.h header so that CONFIG_IS_ENABLED() works. We
> > could avoid this for now by moving the location of the watchdog.h
> > inclusion to outside the USE_HOSTCC area. But at some point the #ifdefs
> > from these files will likely be removed, so there is no benefit in
> > going that way.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> [snip]
> > --- a/include/cyclic.h
> > +++ b/include/cyclic.h
> > @@ -11,6 +11,7 @@
> >  #ifndef __cyclic_h
> >  #define __cyclic_h
> >
> > +#include <linux/kconfig.h>
> >  #include <linux/list.h>
> >  #include <asm/types.h>
>
> As I said, we just need to fix lib/sha*.c so NAK. The only thing that
> stopped me from posting that patch last night was that I went and
> removed <common.h> from everything in lib/ as a follow-up and that's
> taken a few more iterations.
>

Yes I had the same thought the first time and mentioned it
specifically in this version.

If you are a doing a clean-up, perhaps you could drop the #idefs in
the sha files?

Regards,
Simon