[PATCH 2/7] efi: Show the vendor in helloworld

Heinrich Schuchardt xypron.glpk at gmx.de
Tue Nov 21 19:17:59 CET 2023


On 11/21/23 12:35, Simon Glass wrote:
> Show the vendor name since it useful to see that.

With this commit message it remains unclear why displaying the constant
value (u"Das U-Boot") is of any value.

Best regards

Heinrich

>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
>   lib/efi_loader/helloworld.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/lib/efi_loader/helloworld.c b/lib/efi_loader/helloworld.c
> index bd72822c0b72..1135d3a3c37e 100644
> --- a/lib/efi_loader/helloworld.c
> +++ b/lib/efi_loader/helloworld.c
> @@ -234,6 +234,9 @@ efi_status_t EFIAPI efi_main(efi_handle_t handle,
>   			(con_out, u"Missing device path for device handle\r\n");
>   		goto out;
>   	}
> +	con_out->output_string(con_out, u"Vendor: ");
> +	con_out->output_string(con_out, systab->fw_vendor);
> +	con_out->output_string(con_out, u"\n");
>   	con_out->output_string(con_out, u"Boot device: ");
>   	ret = print_device_path(device_path, device_path_to_text);
>   	if (ret != EFI_SUCCESS)



More information about the U-Boot mailing list