[PATCH v4 02/16] arm: mach-k3: Add basic support for J784S4 SoC definition

Andrew Davis afd at ti.com
Wed Nov 22 16:15:56 CET 2023


On 10/4/23 1:06 PM, Nishanth Menon wrote:
> On 23:22-20231004, Apurva Nandan wrote:
> [...]
> 
>>>> +		.virt = 0x500000000UL,
>>>> +		.phys = 0x500000000UL,
>>>> +		.size = 0x400000000UL,
>>>> +		.attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
>>>> +			 PTE_BLOCK_NON_SHARE |
>>>> +			 PTE_BLOCK_PXN | PTE_BLOCK_UXN
>>>> +	}, {
>>>> +		/* List terminator */
>>>> +		0,
>>>> +	}
>>>> +};
>>> Why not reuse CONFIG_SOC_K3_J721S2 or adopt it?
>> The mem_map regions are different for J784S4 from J721S2,
>> and on the hardware side also, i.e. J784S4 has 4x8G DDR slots,
>> so how can we bring it in same CONFIG as J721S2?
> 
> Is'nt that what device tree is for? what harm do we run into if
> we define the common super set in the common file?

Been wanting to fix that for a while now, posted RFC for it here:

https://lore.kernel.org/u-boot/20231122151411.11268-1-afd@ti.com/


More information about the U-Boot mailing list