[PATCH v2 2/9] ufs: Add a line feed to the end of some dev_xxx() messages

[Neha Malcom Francis]

Hi Bin,

On 11/10/23 18:45, Bin Meng wrote:
> Add a line feed to improve readability of some dev_xxx() messages.
> 
> Signed-off-by: Bin Meng <bmeng at tinylab.org>
> ---
> 
> (no changes since v1)
> 
>   drivers/ufs/ufs.c | 16 ++++++++--------
>   1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/ufs/ufs.c b/drivers/ufs/ufs.c
> index f534d6e29f..96801866d3 100644
> --- a/drivers/ufs/ufs.c
> +++ b/drivers/ufs/ufs.c
> @@ -320,7 +320,7 @@ static int ufshcd_disable_tx_lcc(struct ufs_hba *hba, bool peer)
>   					UIC_ARG_MPHY_TX_GEN_SEL_INDEX(i)),
>   					0);
>   		if (err) {
> -			dev_err(hba->dev, "%s: TX LCC Disable failed, peer = %d, lane = %d, err = %d",
> +			dev_err(hba->dev, "%s: TX LCC Disable failed, peer = %d, lane = %d, err = %d\n",
>   				__func__, peer, i, err);
>   			break;
>   		}
> @@ -441,7 +441,7 @@ static int ufshcd_make_hba_operational(struct ufs_hba *hba)
>   		ufshcd_enable_run_stop_reg(hba);
>   	} else {
>   		dev_err(hba->dev,
> -			"Host controller not ready to process requests");
> +			"Host controller not ready to process requests\n");
>   		err = -EIO;
>   		goto out;
>   	}
> @@ -930,7 +930,7 @@ static int ufshcd_copy_query_response(struct ufs_hba *hba)
>   			memcpy(hba->dev_cmd.query.descriptor, descp, resp_len);
>   		} else {
>   			dev_warn(hba->dev,
> -				 "%s: Response size is bigger than buffer",
> +				 "%s: Response size is bigger than buffer\n",
>   				 __func__);
>   			return -EINVAL;
>   		}
> @@ -1179,11 +1179,11 @@ static int ufshcd_read_desc_length(struct ufs_hba *hba, enum desc_idn desc_id,
>   					    &header_len);
>   
>   	if (ret) {
> -		dev_err(hba->dev, "%s: Failed to get descriptor header id %d",
> +		dev_err(hba->dev, "%s: Failed to get descriptor header id %d\n",
>   			__func__, desc_id);
>   		return ret;
>   	} else if (desc_id != header[QUERY_DESC_DESC_TYPE_OFFSET]) {
> -		dev_warn(hba->dev, "%s: descriptor header id %d and desc_id %d mismatch",
> +		dev_warn(hba->dev, "%s: descriptor header id %d and desc_id %d mismatch\n",
>   			 __func__, header[QUERY_DESC_DESC_TYPE_OFFSET],
>   			 desc_id);
>   		ret = -EINVAL;
> @@ -1302,7 +1302,7 @@ int ufshcd_read_desc_param(struct ufs_hba *hba, enum desc_idn desc_id,
>   
>   	/* Sanity checks */
>   	if (ret || !buff_len) {
> -		dev_err(hba->dev, "%s: Failed to get full descriptor length",
> +		dev_err(hba->dev, "%s: Failed to get full descriptor length\n",
>   			__func__);
>   		return ret;
>   	}
> @@ -1323,14 +1323,14 @@ int ufshcd_read_desc_param(struct ufs_hba *hba, enum desc_idn desc_id,
>   					    &buff_len);
>   
>   	if (ret) {
> -		dev_err(hba->dev, "%s: Failed reading descriptor. desc_id %d, desc_index %d, param_offset %d, ret %d",
> +		dev_err(hba->dev, "%s: Failed reading descriptor. desc_id %d, desc_index %d, param_offset %d, ret %d\n",
>   			__func__, desc_id, desc_index, param_offset, ret);
>   		goto out;
>   	}
>   
>   	/* Sanity check */
>   	if (desc_buf[QUERY_DESC_DESC_TYPE_OFFSET] != desc_id) {
> -		dev_err(hba->dev, "%s: invalid desc_id %d in descriptor header",
> +		dev_err(hba->dev, "%s: invalid desc_id %d in descriptor header\n",
>   			__func__, desc_buf[QUERY_DESC_DESC_TYPE_OFFSET]);
>   		ret = -EINVAL;
>   		goto out;

Reviewed-by: Neha Malcom Francis <n-francis at ti.com>

-- 
Thanking You
Neha Malcom Francis