eMMC errors on RK3588 (rock5b)

[Jonas Karlman]

On 2023-11-23 10:58, Eugen Hristev wrote:
> On 11/23/23 07:22, Tom Fitzhenry wrote:
>> I am able to reproduce this on RK3588 QuartzPro64.

I have also been able to reproduce this and made the following finding:

rk35xx: drop ddr52 mode to fix write
rk3568: change txclk tapnum to fix write at hs400 speed
rk3588: enable hs200 mode to fix write
rk3588: drop hs400 mode to fix write

Have not had time to complete test and send patches, should have some
time later this weekend to complete test and send patches.

WIP: rockchip: rk35xx: improve emmc write
https://github.com/Kwiboo/u-boot-rockchip/commit/cb1521aea8dee730bddcc5772afa28aa71fc69f9

Regards,
Jonas

>>
>> I cannot reproduce on the vendor u-boot, used on stock RK3588
>> QuartzPro64. That works fine.
>>
>> I thought "[PATCH v2 RESEND] mmc: dw_mmc: reset controller after data
>> error"[0] might fix this, but after applying that, I am still able to
>> reproduce the issue.
>>
>> 0. https://lore.kernel.org/u-boot/20230619103347.278004-1-eugen.hristev@collabora.com/
> 
> 
> I never said that patch would fix this issue. It fixes another problem 
> that was happening when the controller was resetting. But that issue was 
> arising only in a specific scenario which happened only during my tests. 
> So the fix is here, it's helpful, but not fixing this issue.
> And it appears that this fix will not be accepted to upstream, as it's 
> months since I am resending it.
> 
> Eugen