[PATHv11 20/43] driver/net/rtl8139: remove debug print

[Tom Rini]

On Mon, Nov 27, 2023 at 06:57:03PM +0600, Maxim Uvarov wrote:

> debug print delays reset of the driver. Finally I see
> bunch of "rx error FFFF" errors in the screen. CI can
> not handle many prints. While network works fine there
> 
> Reproduced with:
> make CROSS_COMPILE=sh2-linux- r2dplus_defconfig all
> qemu-system-sh4 -M r2d -nographic -serial null \
> -serial mon:stdio -net user,tftp=`pwd` \
> -net nic,model=rtl8139 -kernel ./u-boot.bin
> 
> Signed-off-by: Maxim Uvarov <maxim.uvarov at linaro.org>
> ---
>  drivers/net/rtl8139.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/rtl8139.c b/drivers/net/rtl8139.c
> index 106bc1c7ae..6003b88274 100644
> --- a/drivers/net/rtl8139.c
> +++ b/drivers/net/rtl8139.c
> @@ -453,7 +453,6 @@ static int rtl8139_recv_common(struct rtl8139_priv *priv, unsigned char *rxdata,
>  			  RTL_STS_RXBADALIGN)) ||
>  	    (rx_size < ETH_ZLEN) ||
>  	    (rx_size > ETH_FRAME_LEN + 4)) {
> -		printf("rx error %hX\n", rx_status);
>  		/* this clears all interrupts still pending */
>  		rtl8139_reset(priv);
>  		return 0;

Make this a debug() please so it's available to interactive developers
with a problem here.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231127/bca1dbe8/attachment.sig>