[PATCH 1/1] pico-imx7d: add baseboard SD card boot detect

Hugo Villeneuve hugo at hugovil.com
Wed Nov 29 00:17:40 CET 2023


On Mon, 27 Nov 2023 23:26:08 +0000 (GMT)
Szőke Kálmán Benjamin <egyszeregy at freemail.hu> wrote:

> It was absolutely conform, i supressed the potentional warning. Once again i say, i will not remove it, if you do not liket it you can remoce as a maintainer. My patch is ready and final. Let's do something to improve i.MX family as a maintainer. I am realy sad to see in last 2-3 years there was no any significats new features for boards since their initial commits.-------- Eredeti levél --------Feladó: Fabio Estevam <festevam at gmail.com>Dátum: 2023 november 27 21:39:19Tárgy: Re: [PATCH 1/1] pico-imx7d: add baseboard SD card boot detectCímzett: Szőke Kálmán Benjamin <egyszeregy at freemail.hu>On Mon, Nov 27, 2023 at 4:55 PM Szőke Kálmán Benjamin <egyszeregy at freemail.hu> wrote: > > Unused function parameters should be removed >
 https://rules.sonarsource.com/c/tag/based-on-misra/RSPEC-1172/  From
this same URL:  "Exceptions There are some cases when you want to have
an unused parameter (usually because the function has to conform to a
fixed prototype"  which is the case here with your patch, where you need to conform to: int board_mmc_get_env_dev(int devno) 

Hi,
please fix your mailer to wrap lines properly.

Hugo Villeneuve.


More information about the U-Boot mailing list