[PATCH 2/2] configs: rockchip: add DOS_PARTITION to RK3308 boards defconfig

Massimo Pegorer massimo.pegorer+oss at gmail.com
Sun Oct 1 15:50:31 CEST 2023


Hi Kever,

Il giorno mer 27 set 2023 alle ore 05:10 Kever Yang
<kever.yang at rock-chips.com> ha scritto:
>
> Hi Massimo,
>
>      This patch is fine to me, but you can merge these two patch into
> one, because they
>
> are all rk3308 boards.

OK, I will merge them in a single v2 patch. Thanks.

I had split them because I had chance to test it only on rock-pi-s, so
I was not sure everybody would have agreed to change also evb and
firefly boards defconfigs.

Regards,
Massimo

>
>      And if you have more than one patch, it'd better to use
> --in-reply-to for follow up patches
>
> so that the mail system know this is a patch set and grab them together.
>
>
> Thanks,
>
> - Kever
>
> On 2023/9/3 01:15, Massimo Pegorer wrote:
> > Without DOS_PARTITION support U-Boot is not able to boot an OS stored
> > into an SD card with MBR partitions table. This is still a quite common
> > case, so add DOS_PARTITION (only for U-Boot proper build) to Rockchip
> > RK3308 EVB and Firefly roc-rk3308-cc board: they are the only RK boards
> > missing of DOS_PARTITION.
> >
> > Signed-off-by: Massimo Pegorer <massimo.pegorer+oss at gmail.com>
> > ---
> >   configs/evb-rk3308_defconfig    | 2 +-
> >   configs/roc-cc-rk3308_defconfig | 2 +-
> >   2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/configs/evb-rk3308_defconfig b/configs/evb-rk3308_defconfig
> > index a13a809c1e..c6472a2c9c 100644
> > --- a/configs/evb-rk3308_defconfig
> > +++ b/configs/evb-rk3308_defconfig
> > @@ -47,7 +47,7 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> >   # CONFIG_CMD_ITEST is not set
> >   # CONFIG_CMD_SETEXPR is not set
> >   # CONFIG_CMD_SLEEP is not set
> > -# CONFIG_DOS_PARTITION is not set
> > +# CONFIG_SPL_DOS_PARTITION is not set
> >   # CONFIG_ISO_PARTITION is not set
> >   CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64
> >   CONFIG_SPL_OF_CONTROL=y
> > diff --git a/configs/roc-cc-rk3308_defconfig b/configs/roc-cc-rk3308_defconfig
> > index 9a789b212f..ca92b8f744 100644
> > --- a/configs/roc-cc-rk3308_defconfig
> > +++ b/configs/roc-cc-rk3308_defconfig
> > @@ -47,7 +47,7 @@ CONFIG_CMD_USB_MASS_STORAGE=y
> >   # CONFIG_CMD_ITEST is not set
> >   # CONFIG_CMD_SETEXPR is not set
> >   # CONFIG_CMD_SLEEP is not set
> > -# CONFIG_DOS_PARTITION is not set
> > +# CONFIG_SPL_DOS_PARTITION is not set
> >   # CONFIG_ISO_PARTITION is not set
> >   CONFIG_EFI_PARTITION_ENTRIES_NUMBERS=64
> >   CONFIG_SPL_OF_CONTROL=y


More information about the U-Boot mailing list