[PATCH v2 19/36] expo: Fix up comments for get_cur_menuitem_text() et al

Simon Glass sjg at chromium.org
Mon Oct 2 03:13:23 CEST 2023


This internal function could use a comment. Add one.

Also tidy up a few other comments.

Signed-off-by: Simon Glass <sjg at chromium.org>

fixup: comments
---

(no changes since v1)

 boot/cedit.c          | 10 ++++++++++
 boot/scene_internal.h |  2 +-
 include/expo.h        |  2 +-
 3 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/boot/cedit.c b/boot/cedit.c
index 73645f70b6cb..1324a8619981 100644
--- a/boot/cedit.c
+++ b/boot/cedit.c
@@ -229,6 +229,16 @@ static int check_space(int ret, struct abuf *buf)
 	return 0;
 }
 
+/**
+ * get_cur_menuitem_text() - Get the text of the currently selected item
+ *
+ * Looks up the object for the current item, finds text object for it and looks
+ * up the string for that text
+ *
+ * @menu: Menu to look at
+ * @strp: Returns a pointer to the next
+ * Return: 0 if OK, -ENOENT if something was not found
+ */
 static int get_cur_menuitem_text(const struct scene_obj_menu *menu,
 				 const char **strp)
 {
diff --git a/boot/scene_internal.h b/boot/scene_internal.h
index 695a907dc6af..42efcee092f3 100644
--- a/boot/scene_internal.h
+++ b/boot/scene_internal.h
@@ -185,7 +185,7 @@ int scene_render_deps(struct scene *scn, uint id);
  * Renders the menu and all of its attached objects
  *
  * @scn: Scene to render
- * @menu: Menu render
+ * @menu: Menu to render
  * Returns: 0 if OK, -ve on error
  */
 int scene_menu_render_deps(struct scene *scn, struct scene_obj_menu *menu);
diff --git a/include/expo.h b/include/expo.h
index a2b3a71c1591..297d892de8e7 100644
--- a/include/expo.h
+++ b/include/expo.h
@@ -505,7 +505,7 @@ int scene_txt(struct scene *scn, const char *name, uint id, uint str_id,
 	      struct scene_obj_txt **txtp);
 
 /**
- * scene_txt_str() - add a new string to expr and text object to a scene
+ * scene_txt_str() - add a new string to expo and text object to a scene
  *
  * @scn: Scene to update
  * @name: Name to use (this is allocated by this call)
-- 
2.42.0.582.g8ccd20d70d-goog



More information about the U-Boot mailing list