[PATCH 22/34] expo: Add a little more cedit CMOS logging
Simon Glass
sjg at chromium.org
Mon Oct 2 03:15:32 CEST 2023
Add some more logging in the CMOS read/write code. Tidy up a few
comments while we are here.
Signed-off-by: Simon Glass <sjg at chromium.org>
---
boot/cedit.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/boot/cedit.c b/boot/cedit.c
index a53a4f289906..cc1d5b763577 100644
--- a/boot/cedit.c
+++ b/boot/cedit.c
@@ -585,7 +585,7 @@ static int h_read_settings_env(struct scene_obj *obj, void *vpriv)
/*
* note that no validation is done here, to make sure the ID is
- * valid * and actually points to a menu item
+ * valid and actually points to a menu item
*/
menu->cur_item_id = val;
break;
@@ -719,6 +719,7 @@ int cedit_write_settings_cmos(struct expo *exp, struct udevice *dev,
}
/* write the data to the RTC */
+ log_debug("Writing CMOS\n");
first = CMOS_MAX_BYTES;
last = -1;
for (i = 0, count = 0; i < CMOS_MAX_BYTES; i++) {
@@ -786,6 +787,7 @@ static int h_read_settings_cmos(struct scene_obj *obj, void *vpriv)
}
/* update the current item */
+ log_debug("look for menuitem value %d in menu %d\n", val, menu->obj.id);
mi = scene_menuitem_find_seq(menu, val);
if (!mi)
return log_msg_ret("seq", -ENOENT);
@@ -820,7 +822,7 @@ int cedit_read_settings_cmos(struct expo *exp, struct udevice *dev,
goto done;
}
- /* read the data to the RTC */
+ /* indicate what bytes were read from the RTC */
first = CMOS_MAX_BYTES;
last = -1;
for (i = 0, count = 0; i < CMOS_MAX_BYTES; i++) {
--
2.42.0.582.g8ccd20d70d-goog
More information about the U-Boot
mailing list