Aw: Re: [PATCH v2 0/7] rockchip: rk3568: Fix use of PCIe bifurcation

[Jonas Karlman]

Hi Frank,

On 2023-10-02 09:17, Frank Wunderlich wrote:
> Hi,
> 
>> Gesendet: Sonntag, 01. Oktober 2023 um 21:11 Uhr
>> Von: "Sebastian Reichel" <sebastian.reichel at collabora.com>
>> An: "Jonas Karlman" <jonas at kwiboo.se>
>> Cc: "Kever Yang" <kever.yang at rock-chips.com>, "Simon Glass" <sjg at chromium.org>, "Philipp Tomsich" <philipp.tomsich at vrull.eu>, "Eugen Hristev" <eugen.hristev at collabora.com>, "Jon Lin" <jon.lin at rock-chips.com>, "FUKAUMI Naoki" <naoki at radxa.com>, "John Clark" <inindev at gmail.com>, u-boot at lists.denx.de
>> Betreff: Re: [PATCH v2 0/7] rockchip: rk3568: Fix use of PCIe bifurcation
>>
>> Hi,
>>
>> On Wed, Sep 27, 2023 at 06:07:59PM +0000, Jonas Karlman wrote:
>>> Above works with this series in U-Boot and also in mainline linux. Not
>>> sure the RK3588 bifurcation part of driver have been verified on real HW,
>>> rk3588 boards available for testing have typicality not used bifurcation.
>>
>> Upstream kernel bifurcation code looks ok to me. It's quite different
>> from Rockchip vendor implementation, which might have confused Kever.
>> I also missed this when having a quick look initially. As you said
>> Rock 5A, Rock 5B and EVB1 do not use bifurcation, so no testing happened
>> on our side.
> 
> my Bananapi R2Pro (rk3568) uses bifurcation and it is working in mainline Linux, but not yet in uboot.

The issue on your Bananapi R2Pro is most likely not related to the
pcie bifurcation code added in this series.

The coded added in this series works same/very similar as on mainline
linux and fixes bifurcation use on devices such as Radxa E25 and NanoPi
R5C/R5S.

Please clarify if pcie work in mainline linux when booting with mainline
u-boot, or does it only work when booting with vendor u-boot? (in case
vendor u-boot set different/default pinconf).

> 
> posted my test-results here:
> https://patchwork.ozlabs.org/project/uboot/patch/20230918173624.31464-1-linux@fw-web.de/#3183519

>From your pci enum command I only see an expected pcie at fe270000 (ngff)
link fail. Does it also print out link fail for pcie at fe280000 (minipcie)?

If not, try running "pci 1" and "pci 2" after an initial "pci enum" to
see if the root complex and your minipcie device is detected.

Regards,
Jonas

> 
> regards Frank
> 
>