[PATCH v2 2/2] board: ti: am64x: Switch to standard boot flow

[Tom Rini]

On Thu, Oct 05, 2023 at 12:14:07PM -0500, Nishanth Menon wrote:
> On 12:31-20231005, Tom Rini wrote:
> [...]
> 
> > > >  /* Now for the remaining common defines */
> > > >  #include <configs/ti_armv7_common.h>
> > > 
> > > It looks like this file still includes distro_bootcmd and defines all
> > > the BOOT_TARGET things. Can they be dropped? Perhaps for now they
> > > could be put behind an #ifdef if other boards need them?
> > > 
> > > I suspect that with your patch as is, the environment is still full of scripts?
> > 
> > There's a lot of TI platforms, so I'm not sure what "#if" you're
> > thinking of might make it cleaner?  We could / should move some of the
> > still relevant content and comments from that file to
> > include/env/ti/ti_armv7_common.env as I do think some of the K3
> > platforms could just drop <configs/ti_armv7_common.h> at this point.
> 
> Is'nt the header distro_bootcmd.h and related stuff under #ifdef
> CONFIG_DISTRO_DEFAULTS already?

That's true too.  The file (and probably all of the other *common.h
ones) likely need some cleaning out of dead comments, etc, from the
Kconfig migration.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231005/a44c23c8/attachment.sig>