[PATCH v2 1/2] binman: openssl: x509: ti_secure_rom: Add support for bootcore_opts

[Neha Malcom Francis]

Hi Simon

On 02/10/23 06:46, Simon Glass wrote:
> Hi Neha,
> 
> On Tue, 26 Sept 2023 at 22:08, Neha Malcom Francis <n-francis at ti.com> wrote:
>>
>> According to the TRMs of K3 platform of devices, the ROM boot image
>> format specifies a "Core Options Field" that provides the capability to
>> set the boot core in lockstep when set to 0 or to split mode when set
>> to 2. Add support for providing the same from the binman DTS. Also

[...]

>>           self.content = fdt_util.GetPhandleList(self._node, 'content-sbl')
>>           input_data_sbl = self.GetContents(required)
>> diff --git a/tools/binman/etype/x509_cert.py b/tools/binman/etype/x509_cert.py
>> index d028cfe38c..fc0bb12278 100644
>> --- a/tools/binman/etype/x509_cert.py
>> +++ b/tools/binman/etype/x509_cert.py
>> @@ -136,7 +136,8 @@ class Entry_x509_cert(Entry_collection):
>>                   imagesize_sysfw_data=self.imagesize_sysfw_data,
>>                   hashval_sysfw_data=self.hashval_sysfw_data,
>>                   sysfw_inner_cert_ext_boot_block=self.sysfw_inner_cert_ext_boot_block,
>> -                dm_data_ext_boot_block=self.dm_data_ext_boot_block
>> +                dm_data_ext_boot_block=self.dm_data_ext_boot_block,
>> +                bootcore_opts=self.bootcore_opts
> 
> When you add args to a function, please update the function comment.
> 

Before sending out the next version, just wanted to mention that this was a 
function call, the function comment has already been updated in 
tools/binman/btool/openssl.py

-- 
Thanking You
Neha Malcom Francis