[PATCH v4 1/4] common: add prototype & rename populate_serial_number()

Simon Glass sjg at chromium.org
Mon Oct 9 19:57:00 CEST 2023


On Mon, 9 Oct 2023 at 08:42, Artur Rojek <artur at conclusive.pl> wrote:
>
> Rename populate_serial_number() to a more descriptive
> serial_read_from_eeprom() and provide the missing function prototype.
>
> This is useful for boards that wish to read their serial number from
> EEPROM at init.
>
> Signed-off-by: Artur Rojek <artur at conclusive.pl>
> ---
>
> v4: - revert to the approach found in v2
>     - keep the new serial_read_from_eeprom() name
>
> v3: - restore original function name and make it static
>     - provide a generic function for reading EEPROM serial number and
>       wrap it around the existing tlv logic
>     - move the env var check out of populate_serial_number() and into
>       the new serial_read_from_eeprom() in order to stay consistent with
>       the documentation
>
> v2: - rename the function
>     - move function documentation from .c file to the prototype location
>
>  cmd/tlv_eeprom.c | 14 +-------------
>  include/init.h   | 14 ++++++++++++++
>  2 files changed, 15 insertions(+), 13 deletions(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list