[PATCH v2 22/27] efi: Depend on CMDLINE for efi_loader

[AKASHI Takahiro]

Hi Simon,

On Sat, Oct 07, 2023 at 05:12:41PM -0600, Simon Glass wrote:
> This features currently requires the command line, so make this
> explicit. Future work could adjust this, but it needs effort within
> the booting support first, like the bootm command.

I a bit doubt this dependency.
EFI_LOADER as library functions doesn't rely on command line support.
What does is, as you mentioned, "bootefi bootmgr" command.
So a more appropriate dependency would be

CMD_BOOTEFI_BOOTMGR
    depends on CMDLINE

CMD_BOOTEFI
    depends on CMDLINE

CMD_EFICONFIG
    depends on CMD_BOOTEFI_BOOTMGR

# CMD_EFIDEBUG can compile without CMD_BOOTEFI_BOOTMGR.

# In my opinion, CMD_BOOTEFI_BOOTMGR should be split into cmd part
  and library part.

-Takahiro Akashi

> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
> (no changes since v1)
> 
>  lib/efi_loader/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 621ed5e5b0fb..2aef9336034e 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -12,6 +12,7 @@ config EFI_LOADER
>  	depends on !EFI_STUB || !X86 || X86_64 || EFI_STUB_32BIT
>  	depends on BLK
>  	depends on !EFI_APP
> +	depends on CMDLINE
>  	default y if !ARM || SYS_CPU = armv7 || SYS_CPU = armv8
>  	select CHARSET
>  	# We need to send DM events, dynamically, in the EFI block driver
> -- 
> 2.42.0.609.gbb76f46606-goog
>