[PATCH 5/4] mkimage: update man page and -h output

Sean Anderson seanga2 at gmail.com
Thu Oct 12 04:17:50 CEST 2023


Hi Rasmus,

On 10/11/23 15:07, Rasmus Villemoes wrote:
> On 11/10/2023 20.37, Tom Rini wrote:
>> On Thu, Sep 28, 2023 at 10:02:57AM +0200, Rasmus Villemoes wrote:
>>
>>> The man page correctly said that -B was ignored without -E, while the
>>> `mkimage -h` output suggested otherwise. Now that -B can actually be
>>> used by itself, update the man page.
>>>
>>> While at it, also amend the `mkimage -h` line to mention the
>>> connection with -E.
>>>
>>> The FDT header is a fixed 40 bytes, so its size cannot (and is not)
>>> modified, while its alignment is a property of the address in RAM one
>>> loads the FIT to, so not something mkimage can affect in any way. (In
>>> the file itself, the header is of course at offset 0, which has all
>>> possible alignments already.)
>>>
>>> Reported-by: Sean Anderson <seanga2 at gmail.com>
>>> Signed-off-by: Rasmus Villemoes <rasmus.villemoes at prevas.dk>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> Applied to u-boot/master, thanks!
>>
> 
> Thanks, but I'm afraid that was premature.
> 
> The original series which this was a fixup/followup for hasn't been
> applied, and Sean had reservations. I'm leaving it to Simon or Tom or
> whoever has final say to decide if they should eventually go in, but it
> would probably be good to get a verdict soonish (it really shouldn't be
> too controversial), and if it's a no, this should just be reverted.

I was hoping you would respond to my most-recent email regarding this series.
In particular:

| Why does mkimage have to do this? Can't you just use truncate or, in a
| binman context, align-size?

Presumably you have some reason for wanting this in mkimage rather than using
existing tooling.

--Sean


More information about the U-Boot mailing list