[PATCH 05/26] arm: imx: Add newlines after error messages

Heinrich Schuchardt xypron.glpk at gmx.de
Thu Oct 12 09:33:16 CEST 2023


On 10/12/23 03:56, Sean Anderson wrote:
> These error messages are missing newlines. Add them.
>
> Fixes: 6e81ca220e0 ("imx: parse-container: Use malloc for container processing")
> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
> ---
>
>   arch/arm/mach-imx/parse-container.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/parse-container.c b/arch/arm/mach-imx/parse-container.c
> index d7275a58c17..c5df78d1c58 100644
> --- a/arch/arm/mach-imx/parse-container.c
> +++ b/arch/arm/mach-imx/parse-container.c
> @@ -85,13 +85,13 @@ static int read_auth_container(struct spl_image_info *spl_image,
>   	}
>
>   	if (container->tag != 0x87 && container->version != 0x0) {
> -		printf("Wrong container header");
> +		printf("Wrong container header\n");

Please, use log_err() and add

    #define LOG_CATEGORY LOGC_ARCH

to the top of the file.

Best regards

Heinrich

>   		ret = -ENOENT;
>   		goto end;
>   	}
>
>   	if (!container->num_images) {
> -		printf("Wrong container, no image found");
> +		printf("Wrong container, no image found\n");
>   		ret = -ENOENT;
>   		goto end;
>   	}



More information about the U-Boot mailing list