[PATCH 13/26] net: Fix compiling SPL when fastboot is enabled

Sean Anderson seanga2 at gmail.com
Thu Oct 12 16:16:29 CEST 2023


On 10/12/23 02:52, Heinrich Schuchardt wrote:
> On 10/12/23 03:56, Sean Anderson wrote:
>> When fastboot is enabled in U-Boot proper and SPL_NET is enabled, we will
>> try to (unsuccessfully) reference it in SPL. Fix these linker errors by
>> conditioning on SPL_UDP/TCP_FUNCTION_FASTBOOT.
>>
>> Signed-off-by: Sean Anderson <seanga2 at gmail.com>
>> ---
>>
>>   net/Makefile | 4 ++--
>>   net/net.c    | 4 ++--
>>   2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/net/Makefile b/net/Makefile
>> index 3e2d061338d..5ea58eef7e4 100644
>> --- a/net/Makefile
>> +++ b/net/Makefile
>> @@ -27,8 +27,8 @@ obj-$(CONFIG_CMD_PCAP) += pcap.o
>>   obj-$(CONFIG_CMD_RARP) += rarp.o
>>   obj-$(CONFIG_CMD_SNTP) += sntp.o
>>   obj-$(CONFIG_CMD_TFTPBOOT) += tftp.o
>> -obj-$(CONFIG_UDP_FUNCTION_FASTBOOT)  += fastboot_udp.o
>> -obj-$(CONFIG_TCP_FUNCTION_FASTBOOT)  += fastboot_tcp.o
>> +obj-$(CONFIG_$(SPL_)UDP_FUNCTION_FASTBOOT)  += fastboot_udp.o
>> +obj-$(CONFIG_$(SPL_)TCP_FUNCTION_FASTBOOT)  += fastboot_tcp.o
> 
> Please, use $(SPL_TPL) so that we don't have to revisit this should we
> ever decide to enable fastboot in SPL in future.

You are going to enable fastboot in TPL?

--Sean



More information about the U-Boot mailing list