[PATCH 4/7] m68k: Remove common.h usage

Tom Rini trini at konsulko.com
Fri Oct 13 17:17:05 CEST 2023


On Fri, Oct 13, 2023 at 08:14:57AM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Thu, 12 Oct 2023 at 16:11, Tom Rini <trini at konsulko.com> wrote:
> >
> > We can remove common.h from most cases of the code here, and only a few
> > places need an additional header instead.
> >
> > Signed-off-by: Tom Rini <trini at konsulko.com>
> > ---
> > Cc: Angelo Dureghello <angelo at kernel-space.org>
> > ---
> >  arch/m68k/cpu/mcf523x/cpu.c         | 1 -
> >  arch/m68k/cpu/mcf523x/cpu_init.c    | 1 -
> >  arch/m68k/cpu/mcf523x/interrupts.c  | 1 -
> >  arch/m68k/cpu/mcf523x/speed.c       | 1 -
> >  arch/m68k/cpu/mcf52x2/cpu.c         | 1 -
> >  arch/m68k/cpu/mcf52x2/cpu_init.c    | 3 +--
> >  arch/m68k/cpu/mcf52x2/interrupts.c  | 1 -
> >  arch/m68k/cpu/mcf52x2/speed.c       | 1 -
> >  arch/m68k/cpu/mcf530x/cpu.c         | 1 -
> >  arch/m68k/cpu/mcf530x/cpu_init.c    | 1 -
> >  arch/m68k/cpu/mcf530x/interrupts.c  | 1 -
> >  arch/m68k/cpu/mcf530x/speed.c       | 1 -
> >  arch/m68k/cpu/mcf532x/cpu.c         | 1 -
> >  arch/m68k/cpu/mcf532x/cpu_init.c    | 1 -
> >  arch/m68k/cpu/mcf532x/interrupts.c  | 1 -
> >  arch/m68k/cpu/mcf532x/speed.c       | 1 -
> >  arch/m68k/cpu/mcf5445x/cpu.c        | 1 -
> >  arch/m68k/cpu/mcf5445x/cpu_init.c   | 1 -
> >  arch/m68k/cpu/mcf5445x/dspi.c       | 1 -
> >  arch/m68k/cpu/mcf5445x/interrupts.c | 1 -
> >  arch/m68k/cpu/mcf5445x/speed.c      | 1 -
> >  arch/m68k/cpu/mcf5445x/start.S      | 1 -
> >  arch/m68k/include/asm/immap.h       | 1 +
> >  arch/m68k/include/asm/immap_520x.h  | 1 +
> >  arch/m68k/include/asm/immap_5235.h  | 1 +
> >  arch/m68k/include/asm/immap_5272.h  | 1 +
> >  arch/m68k/include/asm/immap_5275.h  | 1 +
> >  arch/m68k/include/asm/immap_5282.h  | 1 +
> >  arch/m68k/include/asm/immap_5301x.h | 1 +
> >  arch/m68k/include/asm/immap_5307.h  | 2 ++
> >  arch/m68k/include/asm/immap_5329.h  | 1 +
> >  arch/m68k/include/asm/immap_5441x.h | 1 +
> >  arch/m68k/lib/bdinfo.c              | 3 ++-
> >  arch/m68k/lib/bootm.c               | 1 -
> >  arch/m68k/lib/cache.c               | 2 +-
> >  arch/m68k/lib/fec.c                 | 2 +-
> >  arch/m68k/lib/interrupts.c          | 2 +-
> >  arch/m68k/lib/time.c                | 1 -
> >  arch/m68k/lib/traps.c               | 1 -
> >  39 files changed, 17 insertions(+), 30 deletions(-)
> 
> I just wondered what we do about '#ifdef CFG_...' which presumably is
> not included without common.h ? How does that work?

The first header in common.h is config.h which is where many CFG_...
instances are.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20231013/f0e8a3ec/attachment.sig>


More information about the U-Boot mailing list